> From: Stuart Henderson > Sent: Monday, May 21, 2018 1:46 PM > > It's the upstream build system that is building them with odd > names here, ports doesn't have much to do with this.
Oh, okay; I thought you were objecting to the way I was creating the symlinks in the makefile, not the existence of the version numbers themselves. > .so files intended as dlopen'd modules should not normally have a > version in the filename anyway, there might be some missing libtool Dunno; I'll ask upstream and see if they have anything to say about it. > I think basically tell users what lines to add to get the same as they > have now, then they can remove bits which they don't need. Okay, how about: "The openldap port has been updated to use dynamically loaded modules rather than compile everything statically into a monolithic binary. To accommodate this change, you will need to update your configuration to include "modulepath /usr/local/libexec/openldap" as well as a moduleload for each module your configuration avails of. For example, if your configuration includes "database mdb", you will need to add a "moduleload back_mdb.so", or "moduleload back_bdb.so" for "database bdb", etc. if you are using replication, you will need "moduleload syncprov.so" and possibly "moduleload accesslog.so". Please see the documentation at http://www.openldap.org/doc/admin24/for additional details on configuring openldap." > The file is installed to ${PREFIX}/share/examples/openldap/slapd.conf, > that's the file where I'd add as an example. Actually, that file already includes: # Load dynamic backend modules: # modulepath /usr/local/libexec/openldap # moduleload back_mdb.la # moduleload back_ldap.la which the current port wouldn't even work with… Do you think that's sufficient, or that it needs a tuneup? > It might be worth @sample'ing > this file into ${SYSCONFDIR}/openldap as well, I think it was just an > oversight that this wasn't done before.. Okay, looks like that is just adding @sample ${SYSCONFDIR}/openldap/slapd.conf under share/examples/openldap/slapd.conf > hmm, with aci turned into a module, we should be able to get rid > of the FLAVOR Seems reasonable; I don't think there are any additional dependencies for compiling it, and if you don't load the module, it will be the same operationally as if it didn't exist. Is that just removing these lines from the makefile: # overwrite -main pkgname/path to strip FLAVOR, aci only affects the server FULLPKGNAME-main = ${DISTNAME:S/-/-client-/}${FLAVOR_EXT:S/-aci//} FULLPKGPATH-main = databases/openldap,-main${FLAVOR_EXT:S/-aci//:S/-/,/g} .if ${FLAVOR:Maci} CONFIGURE_ARGS += --enable-aci=mod .endif and then updating FLAVORS = aci gssapi to FLAVORS = gssapi ?
