On 2018/05/21 08:05, Landry Breuil wrote: > On Sun, May 20, 2018 at 07:43:41PM -0700, Paul B. Henson wrote: > > This patch updates the openldap port to use modules instead of being > > monolithic. I've been using it in production for six months or so and > > haven't had any issues. > > It needs a bit more than that: > - the versionning of the modules feels 'wrong', and should be fixed > within the build system.
yes, there's definitely something wrong there. which are the actual names used to dlopen them? also the wonderful openldap documentation (the "best" reference I've found so far seems to be https://www.openldap.org/faq/data/cache/362.html) suggests that .la files should be used rather than using .so files directly. > imo, we should just have .so files with or without the > -2.4 suffix, depending whether we plan to have the same for 2.3 and the > server is able to find them (ie look at the code listing the modules) as far as I'm concerned 2.3 can be left to rot ;-) > - this definitely needs a current.html entry to warn people of the > configuration changes, because in the current state afair all the > modules are bundled/available, and your proposition would force people > to load the modules they actually use. yep, probably also patch the sample config file showing the important ones..
