On Sat, May 12, 2018 at 11:33:11AM +0200, Klemens Nanni wrote: > On Sat, May 12, 2018 at 10:27:20AM +0200, Ingo Feinerer wrote: > > please find attached a port for qrcode, a pure python QR Code generator: > > https://github.com/lincolnloop/python-qrcode > Looks good, but some tests fail, test.log attached.
Yes. pymaging is missing (not in ports tree as Ljuba Nedeljkovic mentioned). I have no immediate plans to port it but think activated (partly failing) tests are better than NO_TEST. > I'd patch setup.py, `sed -i' always seems dirty to me except for bulk > cases where you want to avoid all the patch churn for the same > substitution across lots of files. Done. > With COMMENT, DISTNAME and CATEGORIES column aligned, it's a tad easier to > read, imho. Done. (The indentation comes from infrastructure/templates/Makefile.template which I try to adhere to typically.) > On 2018/05/12 08:50, Daniel Jakots wrote: > > Also the README shows it can be used as a library, wouldn't it make > > more sense to name the port py-qrcode and provide both python flavours? Done. But there is one problem now which I am unsure about: Both flavors install bin/qr and man/man1/qr.1; isn't that a conflict? If yes, what is the best strategy to solve this? Thanks all for the input. Best regards, Ingo
py-qrcode.tar.gz
Description: application/tar-gz
