On 2018/05/09 15:36, Thomas Frohwein wrote: > Please find attached a draft for a port of unbound. While openbsd does have > unbound binary in base, the upcoming port of monero needs headers and library > of unbound. This port draft satisfies this dependency. > > A few comments on the port: > * disabled doxygen > * unittest shows this warning, unclear why, but $? is 0: > [1525898278] unbound[50489:0] warning: duplicate response-ip action for > '192.0.1.0/24', overridden. > * It comes with its own set of man pages, most of which are already in base > (slightly older version, though).
First off there are some possible alternatives to importing this: - Just considering monero, they have a copy in their own tree, it might be simpler to use that statically linked in this instance. - Perhaps it's simpler to move unbound back to ports rather than dealing with the split. I sense some discontent with it in base anyway, and that would also let us enable (at least via flavours) some pieces that can't be done in base (python, libsodium). Otherwise: For a libunbound package, please skip the daemon and tools, easiest way is probably "ALL_TARGET=lib" and "INSTALL_TARGET=install-lib". The .pc file is installed from the wrong target (install-all not install-lib) so just handle that in post-install for now. There was an old unbound package so SHARED_LIBS needs to start 'above' that at 4.0 and @conflict unbound-*. Please remove unused AUTOCONF_VERSION/AUTOMAKE_VERSION. Need to make sure it doesn't interfere with building unbound in base if installed. I think it's unlikely but would want checking. I'm not sure what to do with sysconfdir, the way it's set now is wrong because it's actually pointing at /etc/unbound/unbound/unbound.conf. I think this is usually unused for the library but does appear in the produced .so file, so I'm unsure whether it's best to point at /var/unbound/etc from base, or just leave at default (avoid touching SYSCONFDIR in the port). However that's done, I don't think @sample is needed for a libunbound package (the current one isn't working as intended anyway, it copies /usr/local/sbin/unbound-host to /etc/unbound/unbound.conf).
