On Wed, Apr 25, 2018 at 12:12:10PM +0100, Stuart Henderson wrote:
> On 2018/04/25 13:15, mazocomp wrote:
> > On Wed, Apr 25, 2018 at 10:56:07AM +0100, Stuart Henderson wrote:
> > > On 2018/04/25 12:51, mazocomp wrote:
> > > > > - net/toxic: use the python module, don't RUN_DEPENDS +=
> > > > > lang/python/3.6
> > > > >
> > > > It's an error to use python module in this port:
> > >
> > > It's an error to _not_ use the python module in a port that uses python
> > > because it will cause pain when we switch versions - easy fix for this
> > > though:
> > >
> > > > ===> Building for toxic-0.8.2
> > > > /usr/local/bin/python3.6: can't open file './setup.py': [Errno 2] No
> > > > such file or directory
> > > > *** Error 2 in . (/usr/ports/lang/python/python.port.mk:185 'do-build':
> > > > @: ;mkdir -p /tmp/pobj/toxic-0.8.2-python3/lib/python3.6/site-packag...)
> > > > *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2736
> > > > '/tmp/pobj/toxic-0.8.2-python3/.build_done')
> > > > *** Error 1 in /usr/ports/openbsd-wip/net/toxic
> > > > (/usr/ports/infrastructure/mk/bsd.port.mk:2417 'all')
> > >
> > > set CONFIGURE_STYLE=none.
> > >
> >
> > Ok, I am done. Also I had a pain with MODPY_VERSION variable, so I just
> > renamed flavor python to python3.
> >
> > Here is corrected version of these ports:
>
> Thanks, so now I've done a build test and noticed a couple other things
>
> >=< toxcore:
>
> "SEPATATE_BUILD" - typo, plus it is set by default for cmake ports, please
> remove
> the line.
>
Ok.
> TEST_TARGET = check
> doesn't work; please either repair or use NO_TEST=Yes instead
>
> there are some time_t problems but only in the auto_tests dir.
> not a showstopper, but even if tests are fixed they'll probably
> fail on ILP32 arches.
>
> COMPILER_LIBCXX seems unneeded; only used in (not-installed) test files?
>
I didn't know what extra word means, all I did was updating the work of
Dmitriy Czarkoff and Pascal Stumpf. Ok, I set NO_TEST to Yes
> >=< toxic:
>
> ignores CFLAGS
>
I am stuck here. Do you mean CFLAGS is not setable externally?
> python3 flavour is missing LIB_DEPENDS on ${MODPY_LIB_DEPENDS} (masked by
> RUN_DEPENDS), also missing WANTLIB on ${MODPY_WANTLIB} intl util
>
Ok.
> FLAVOR=python3 or FLAVOR="python3 no_x11" just produces a package named
> toxic-0.8.2 or toxic-0.8.2-no_x11 (check with make show=PKGNAMES with
> FLAVOR set in various ways). This is a bad interaction with python.port.mk's
> python3 package support. One possible fix would be to name the flavour "py"
> instead of python or python3.
>
> FLAVOR=no_x11 has Extra: vpx
>
> FLAVOR="notify no_x11" has Extra: m vpx
>
> There doesn't seem a lot of point in no_x11 if it's going to pull in
> desktop-file-utils; is there really an advantage to having all these
> flavours anyway? they do make testing and updates more complicated.
>
Having notify flavor has only advantage not to install libnotify, no_x11
has minor advantage: if Toxic runs in tmux session, it may crash if
you'll stop running terminal emulator at X11 session. Ok, I am removing
all these flavors.
> >=< uTox:
>
> overrides optimizer flags from CFLAGS by adding -Os, otherwise looks good
>
>
Ok.
