On Wed, Apr 25 2018, Solene Rapenne <sol...@perso.pw> wrote:
> here is a port of py-pgpdump which is required for the port of
> mail/mailpile which I'll submit soon.
>
> there is one patch disabling a failing test due to a missing file. That
> file is available in the github repository but not in the tarball
> downloaded on pypi. It has been reported in september 2016 on the
> project github without answer.
>
> the tests pass with python2 and python3
Looks mostly good, here's what I found:
- there's no actual dependency on security/pgpdump, this is really
a python reimplementation, so we should remove security/pgpdump from
BUILD/RUN_DEPENDS. I'd also suggest amending the COMMENT, something
like "python binding for parsing PGP packets"
- please make do-test depend on do-install instead of fake, so that
''make clean test'' works ootb.
- please regen the PLIST (using the python3 FLAVOR), and fix the
"duplicate item in packing-list" error by prefixing the offending line
with ${MODPY_COMMENT}
Also, I'm not sure it's worth patching out the failing test, I think
it's clear from the error message that the issue is not a bug. Also if
the next update adds the missing file, we'll have to remember to remove
the patch or we'll miss a test.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
