REVISION-main = R looks like a typo, should be kept at 0,
Otherwise ok with me
I would question the use of lang/ghc, as MODULE = lang/ghc already sets
things, then need to use += in BUILD_DEPENDS, for now ok.
On 04/21/18 21:10, Matthias Kilian wrote:
> Hi,
>
> On Fri, Apr 20, 2018 at 11:00:48PM +0100, Nigel Taylor wrote:
>> Makefile has
>>
>> RUN_DEPENDS-lib = ${BUILD_DEPENDS}
>>
>> In the case of USE_CCACHE being set to Yes devel/ccache is added to the
>> build dependencies, when not required at runtime.
>
> Right. The diff basically swaps those two and also removes the
> unneeded empty assignment to LIB_DEPENDS-lib.
>
> Any objections?
>
> Ciao,
> Kili
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/shellcheck/Makefile,v
> retrieving revision 1.2
> diff -u -p -r1.2 Makefile
> --- Makefile 14 Apr 2018 19:48:36 -0000 1.2
> +++ Makefile 21 Apr 2018 20:05:38 -0000
> @@ -7,7 +7,8 @@ COMMENT-lib = ShellCheck library
>
> V = 0.4.7
> DISTNAME = ShellCheck-${V}
> -REVISION = 0
> +REVISION-main = R
> +REVISION-lib = 1
> PKGNAME-main = shellcheck-${V}
> PKGNAME-lib = hs-shellcheck-${V}
> CATEGORIES = devel
> @@ -28,7 +29,8 @@ MODGHC_BUILD = cabal hackage haddock re
>
> MODGHC_PACKAGE_KEY = FGszl8wDu4DoQ1UCsbZPa
>
> -BUILD_DEPENDS += devel/hs-mtl>=2.2.1 \
> +BUILD_DEPENDS = ${RUN_DEPENDS-lib}
> +RUN_DEPENDS-lib = devel/hs-mtl>=2.2.1 \
> devel/hs-parsec \
> devel/hs-QuickCheck>=2.7.4 \
> devel/hs-regex-tdfa \
> @@ -36,8 +38,6 @@ BUILD_DEPENDS += devel/hs-mtl>=2.2.1 \
> textproc/hs-json
> LIB_DEPENDS-main = converters/libiconv
> RUN_DEPENDS-main =
> -LIB_DEPENDS-lib =
> -RUN_DEPENDS-lib = ${BUILD_DEPENDS}
>
> NO_TEST = Yes
>
>
