> Date: Tue, 17 Apr 2018 21:43:17 +0200 > From: Klemens Nanni <k...@openbsd.org> > > On Sun, Apr 15, 2018 at 06:34:21PM +0200, Markus Hennecke wrote: > > On Sat, 14 Apr 2018, Jeremie Courreges-Anglas wrote: > > > > > On Thu, Apr 12 2018, Klemens Nanni <k...@openbsd.org> wrote: > > > > On Sat, Apr 07, 2018 at 08:26:10AM +0200, Markus Hennecke wrote: > > > >> With the attached fix the redis port builds, but is unable to complete > > > >> the > > > >> regression tests (see https://github.com/antirez/redis/issues/4640). > > > > What's the status on armv7 without this fix? > > > [ ] > > > > Have you tried the newer > > > > 4.0.9 version? > > > > > > *I* haven't, but the snippet above is still in the master branch > > > upstream, so I wouldn't expect an improvement. > > > > No change with 4.0.9. The build still needs one of the fixes > > proposed in this thread and the regression tests still fail. > 4.0.9 looks good here on amd64 and sparc64, too. > > > > > I don't have access to that platform but the diff looks ok port-wise. > > > > > > > > There's another redis diff from me pending on ports@. but I'd also like > > > > to update the port to 4.0.9, maybe we can combine this with your fix? > > > > > > Personally I prefer when different issues are addressed by separate > > > commits. > > > > > > > > > Index: patch-src_Makefile > > > =================================================================== > > > RCS file: /d/cvs/ports/databases/redis/patches/patch-src_Makefile,v > > > retrieving revision 1.27 > > > diff -u -p -p -u -r1.27 patch-src_Makefile > > > --- patch-src_Makefile 9 Aug 2017 09:16:09 -0000 1.27 > > > +++ patch-src_Makefile 14 Apr 2018 00:27:57 -0000 > > > @@ -21,6 +21,15 @@ Index: src/Makefile > > > INSTALL=install > > > > > > # Default allocator defaults to Jemalloc if it's not an ARM > > > +@@ -40,7 +41,7 @@ endif > > > + > > > + # To get ARM stack traces if Redis crashes we need a special C flag. > > > + ifneq (,$(findstring armv,$(uname_M))) > > > +- CFLAGS+=-funwind-tables > > > ++# CFLAGS+=-funwind-tables > > > + endif > > > + > > > + # Backwards compatibility for selecting an allocator > > > @@ -66,7 +67,7 @@ endif > > > FINAL_CFLAGS=$(STD) $(WARN) $(OPT) $(DEBUG) $(CFLAGS) $(REDIS_CFLAGS) > > > FINAL_LDFLAGS=$(LDFLAGS) $(REDIS_LDFLAGS) $(DEBUG) > > > > > > > This won't pull in libc++abi, so I think it would be a much cleaner > > solution port wise. > I agree. > > OK kn if one of you wants to go ahead and fix armv7.
I'm travelling and don't have a lot of spare cycles to participate in this discussion at the moment. I have suggested providing a separate libunwind in base with the LLVM unwinder. I think I even provided a diff at some point. But it is up to you ports guys to decide whether that is helpful or not. Some ports may pick this up automatically but may expect a different libunwind implementation and therefore break.
