On Tue, Mar 06, 2018 at 02:28:12PM +0100, Alexander Bluhm wrote: > On Sun, Feb 25, 2018 at 04:13:38PM +0100, Frederic Cambus wrote: > > Here is a new port: converters/p5-Sereal-Encoder > > I had some problems with linking -lzstd especially when this package > was installed. I would recommend to add archivers/zstd as lib > dependency and always use the library from the existing package. > > Also for the included Devel::CheckLib we have a package. I prefer > to add dependencies and remove the included stuff. Then I am sure > which software is used after all this build magic.
That makes sense to me, thanks for pointing this out. > I think the following things should change: > - There are some source files with different license, the comment > should include them. > - add zstd to wantlib > - depend on devel/p5-Devel-CheckLib and archivers/zstd > - according to Makefile.PL p5-Sereal-Decoder version >=4.002 is > needed for testing. I prefer to keep the version in sync with > our test dependecies. > - remove the unused Devel/CheckLib and zstd > - patch to search for libraries in /usr/local > > I have included my proposed changes for p5-Sereal-Encoder. Again, thanks for this. I applied the same changes to p5-Sereal-Decoder, attaching updated tarballs.
p5-Sereal-Encoder.tar.gz
Description: application/tar-gz
p5-Sereal-Decoder.tar.gz
Description: application/tar-gz
