Ok, thank you for the helpful feedback. I will implement the changes
and cc the maintainer on the next revision of the patch later today.
-- Currell
On Sun, Mar 18, 2018 at 4:34 AM, Landry Breuil <lan...@openbsd.org> wrote:
> On Sun, Mar 18, 2018 at 09:21:13AM +0100, Landry Breuil wrote:
>> On Sat, Mar 17, 2018 at 11:35:14PM -0400, Currell Berry wrote:
>> > From the Changelog it appears that tkcvs 6.0 is somewhere around 20
>> > years old -- upstream has changed a lot in the interim.
>> >
>> > NOTE: this change additionally requires you to manually delete the
>> > patches folder in devel/tkcvs. No patches are needed on the new
>> > version, because the new installer lets you specify the destination
>> > directory from the command line. I couldn't figure out how to make cvs
>> > make a patch which showed the folder deletion! I am a beginner at CVS
>> > and at Porting, so please let me know if there is something I should
>> > be doing differently.
>>
>> Minor things:
>> - you cant "delete" a folder in CVS, you just remove the files in it,
>> cvs diff will show them deleted, and cvs up -P will delete the dir
>> from you local checkout
>> - this port has a maintainer, so when sending diffs for such port it's
>> required to cc him
>> - i suppose you're removing the @conflict on kde-dev-scripts because
>> cvscheck is gone from the PLIST - in that case better telling it
>> instead of having ppl reading the diff trying to figure out why :) - and
>> in that case the @conflict tkcvs-* in kde-dev-scripts should also be
>> removed
>> - when updating to a new version you should remove REVISION
>> - Tk, CVS and subversion - such a win combination :)
>>
> Oh, and as is it wont start:
>
> /usr/local/bin/tkcvs[4]: wish: not found
>
> 'wish' as a binary itself doesnt exist by default, so you need to use
> MODTCL_WISH_ADJ as an additional command in do-install to 'fix' the
> interpreted used by the scripts.
>
> do-install:
> cd ${WRKSRC} && ${MODTCL_WISH_ADJ} tkcvs/tkcvs.tcl tkdiff/tkdiff.tcl
> cd ${WRKSRC} && $(MODTCL_BIN) ./doinstall.tcl -nox ${PREFIX}
>
> Maybe http://www.twobarleycorns.net/ could be used as HOMEPAGE too.
>
