On 2018/03/11 10:56, Remi Locherer wrote:
> On Sun, Mar 11, 2018 at 09:07:03AM +0000, Stuart Henderson wrote:
> > On 2018/03/10 22:11, Daniel Jakots wrote:
> > > On Thu, 8 Mar 2018 22:18:01 +0100, Remi Locherer
> > > <remi.loche...@relo.ch> wrote:
> > >
> > > > +RUN_DEPENDS-elasticsearch = ${PKGNAME-main}:${PKGPATH},-main
> > >
> > > > + --enable-elasticsearch \
> > >
> > > You added a subpackage for ES but shouldn't we have a ldep on
> > > elasticsearch as it is with mysql/mariadb?
> > >
> > > With that added (unless you think it's wrong), ok danj@
> > >
> >
> > That is wrong, the elasticsearch package does not provide a library so
> > a LIB_DEPENDS dependency would just be stripped ("not needed for" message).
> >
>
> Exactly. The module omelasticsearch.so talks http with ES and for that it
> links to libcurl and libnghttp2.
>
> > Since there is no extra dependency for this (I guess it just talks http),
> > I'd probably roll it into the main package, though having it as a separate
> > package is ok too.
>
> If it's preferable I can remove the subpackage and move the module to the
> main package. I made it a subpackage because the other db output modules
> are. One advantage of it being a subpackage might be that its easier to
> find this functionality for an admin. But I don't have a strong opinion
> on this.
Really I'm ok with it either way, that's exactly the reason for having it
separate. If I was writing the port myself I'd roll it in, but totally
happy with it separate.
I think you should go ahead and commit, ok sthen@.
