On Tue 13/02/2018 20:59, Antoine Jacoutot wrote: > On Tue, Feb 13, 2018 at 07:24:58PM +0000, Björn Ketelaars wrote: > > On Tue 13/02/2018 20:01, Landry Breuil wrote: > > > On Tue, Feb 13, 2018 at 06:37:47PM +0100, Björn Ketelaars wrote: > > > > Diff below brings potamus to the latest version. While here add > > > > SEPARATE_BUILD=Yes to Makefile. > > > > > > What is it with this ? I see you're adding it to Makefiles, is there a > > > particular reason for it ? If it's *better* generally, then maybe a > > > (much larger) task would be to switch it by default and only set it to > > > no for broken ports.. > > > > It has some advantages, and testing it while working on a port is cheap. > > From https://www.openbsd.org/faq/ports/guide.html: > > > > - If the port can build with object files outside its source tree, this > > is cleaner (many programs using CONFIGURE_STYLE=gnu can), and may help > > people who mount their ports tree on several arches. > > You still can. Just use a local partition for your objdir. > > > - This can also spare you some effort, as you will possibly be able to > > restart the cycle at configure most of the time. > > I agree with Landry. > I don't like to start adding this to ports unless this is required. Now, if we > want to make it a default, than fine, someone starts the effort...
Clear! Until I understand the internals better I'm not going to start the effort. Attached a new diff without the SEPARATE_BUILD bit. OK? Index: Makefile =================================================================== RCS file: /cvs/ports/audio/potamus/Makefile,v retrieving revision 1.6 diff -u -p -r1.6 Makefile --- Makefile 16 Nov 2017 19:52:09 -0000 1.6 +++ Makefile 13 Feb 2018 20:25:26 -0000 @@ -1,9 +1,8 @@ # $OpenBSD: Makefile,v 1.6 2017/11/16 19:52:09 kirby Exp $ COMMENT = lightweight audio player with a simple interface -DISTNAME = potamus-16 +DISTNAME = potamus-17 CATEGORIES = audio x11 -REVISION = 2 HOMEPAGE = http://offog.org/code/potamus/ Index: distinfo =================================================================== RCS file: /cvs/ports/audio/potamus/distinfo,v retrieving revision 1.3 diff -u -p -r1.3 distinfo --- distinfo 22 Nov 2014 06:42:39 -0000 1.3 +++ distinfo 13 Feb 2018 20:25:26 -0000 @@ -1,2 +1,2 @@ -SHA256 (potamus-16.tar.gz) = CzGVX1SVR31oBIkVVg5SjRPXQRePuQ7znj/y28rXrmM= -SIZE (potamus-16.tar.gz) = 144874 +SHA256 (potamus-17.tar.gz) = zRBISxZwZHyu+z1YYjpsF6e68EfiMFn7KDRF4X1Qa4o= +SIZE (potamus-17.tar.gz) = 146822
