On Fri, Feb 09, 2018 at 07:12:28PM +0100, Björn Ketelaars wrote:
> On Fri 09/02/2018 17:11, Stuart Henderson wrote:
> > On 2018/02/09 13:44, Landry Breuil wrote:
> > > On Fri, Feb 09, 2018 at 01:29:36PM +0100, Bjorn Ketelaars wrote:
> > > > Included a diff for bringing sysutils/burp to the latest version.
> > > > Changelog can be found at http://burp.grke.org/changelog.html
> > > > 
> > > > I removed 2 patches as the issues have been solved upstream.
> > > > 
> > > > Output 'make test':
> > > > 
> > > > 100%: Checks: 348, Failures: 0, Errors: 0
> > > > 
> > > > I only did some very, very light testing. Only thing that I'm sure about
> > > > is that it doesn't blow up.
> > > 
> > > I didnt port 2.1 branch on purpose as at that time, upstream considered
> > > it "development" - but it see now that it's been promoted to stable,
> > > good.
> > 
> > Yes, but only last week. Good to send the diff out for testing but unless
> > someone has been running 2.1.x regularly on OpenBSD during dev, it would
> > probably be better to hold off a little before actually updating.
> 
> What sthen@ writes makes sense, especially as I'm not a burp user. In
> the meantime I did test the internalised timer functionality. It seems
> to work. I also tested the ncurses monitor client (burp -a s). It works
> after 'monitor_exe=path_to_burp' has been set in burp.conf. For details
> see
> https://github.com/grke/burp/commit/2f8caac60da0cb713054276440656b5581878b4f
> 
> I think it makes sense to set the latter in OpenBSD's port. As such,
> a new diff. In this diff I also removed bash as RDEP.  There is no need
> for bash in a plain vanilla setup (there are no scripts defined).

Oh right i remember upstream added it after i told him about not using
/proc to find the exe...
as for bash, iirc there are other scripts shipped in the pkg that might
need it. Will have to recheck.

Reply via email to