On 01/16/18 16:54, Victor Kukshiev wrote:
ping.

2018-01-12 20:11 GMT+03:00 Victor Kukshiev <andrey0bolkon...@gmail.com>:

hello!
I was partial ported GNOME games.

in this archive:
gnome-mahjongg https://wiki.gnome.org/Apps/Mahjongg
gnome-chess https://wiki.gnome.org/Apps/Chess
gnome-sudoku https://wiki.gnome.org/Apps/Sudoku
hitori https://wiki.gnome.org/Apps/Hitori
swell-foop https://wiki.gnome.org/Apps/Swell%20Foop

okay?


It is a must that you run portcheck before submitting any ports. portcheck identified a number of issues in every single one of these ports. You must at a minimum address all the issues in portcheck, though these ports have further issues beyond just what portcheck has identified.

As a courtesy, I went ahead and fixed up gnome-chess. Fix the others like I did this one, then resubmit.

Additionally, if these ports are going to live in x11/gnome (Antoine?) then dropping the gnome- prefix from the port directory will have to be done as well.

~Brian

Attachment: gnome-chess.tgz
Description: Binary data

Reply via email to