On 2018/01/14 20:19, Klemens Nanni wrote:
> On Tue, Jan 02, 2018 at 04:16:25PM +0100, Rafael Sadowski wrote:
> > Simple update to the latest stable version. Comments? Ok?
> >
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/mail/mairix/Makefile,v
> > retrieving revision 1.15
> > diff -u -p -u -p -r1.15 Makefile
> > --- Makefile 1 Nov 2014 17:17:53 -0000 1.15
> > +++ Makefile 2 Jan 2018 15:14:49 -0000
> > @@ -2,7 +2,7 @@
> >
> > COMMENT= program for indexing & searching email
> >
> > -DISTNAME= mairix-0.23
> > +DISTNAME= mairix-0.24
> > CATEGORIES= mail
> > HOMEPAGE= http://www.rpcurnow.force9.co.uk/mairix/
> >
> > @@ -12,7 +12,7 @@ PERMIT_PACKAGE_CDROM= Yes
> > MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=mairix/} \
> > http://www.rpcurnow.force9.co.uk/mairix/
> >
> > -WANTLIB= c z bz2
> > +WANTLIB += bz2 c crypto ssl z
> >
> > BUILD_DEPENDS= devel/bison
> > LIB_DEPENDS= archivers/bzip2
> > @@ -20,7 +20,5 @@ LIB_DEPENDS= archivers/bzip2
> > CONFIGURE_STYLE= simple
> > CONFIGURE_ENV= CPPFLAGS="-I${PREFIX}/include" \
> > LDFLAGS="-L${PREFIX}/lib"
> > -
> > -NO_TEST= Yes
> It seems you didn't run the tests. TEST_TARGET is still incorrectly set
> to "test". When run, it errors out immediately:
>
> $ make TEST_TARGET=check test
> ===> Regression tests for mairix-0.24
> if [ -d test ]; then cd test ; make CC="cc" CFLAGS="-O2 -pipe
> -DHAS_STDINT_H -DHAS_INTTYPES_H -DUSE_GZIP_MBOX -DUSE_BZIP_MBOX
> -DUSE_OPENSSL" check ; else echo "No test subdirectory?" ; exit 1 ; fi
> scripts/print_test_statistics.sh
> scripts/print_test_statistics.sh: not found
> *** Error 1 in test (Makefile:74 'check')
> *** Error 2 in /usr/obj/ports/mairix-0.24/mairix-0.24 (Makefile:115
> 'check')
> *** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2777
> '/usr/obj/ports/mairix-0.24/.test_done')
> *** Error 1 in /usr/ports/mail/mairix
> (/usr/ports/infrastructure/mk/bsd.port.mk:2419 'test')
>
That should be easy to fix, bad #! line (/bin/bash).
It does need bash, we don't have the string chopping stuff:
$ checkbashisms -f test/scripts/print_test_statistics.sh
possible bashism in test/scripts/print_test_statistics.sh line 41
(${foo:3[:1]}):
NAME_START=${NAME_STUB:0:1}
