On 2018/01/14 11:14, Landry Breuil wrote: > On Sun, Jan 14, 2018 at 11:09:05AM +0100, Björn Ketelaars wrote: > > On Sun 14/01/2018 10:10, Landry Breuil wrote: > > > On Sun, Jan 14, 2018 at 08:41:34AM +0100, Björn Ketelaars wrote: > > > > Enclosed a diff for bringing joe to the latest version (4.6), which > > > > fixes > > > > a couple of bugs. Changelog can be found at > > > > https://sourceforge.net/p/joe-editor/mercurial/ci/default/tree/NEWS.md > > > > > > > > Output of 'make lib-depends-check' indicates that curses should be > > > > included as > > > > WANTLIB instead of ncurses. > > > > > > > > Comments? > > > > > > Maybe portcheck warns about it, but if somehonw files are added into > > > share/applications; then you need to run depends on desktop-file-utils, > > > update the plist so that the share/applications dir is removed from it, > > > and add the corresponding @exec @unexec-delete goos as found in many > > > other ports. Or if you dont want to add the dependency, @comment the > > > entries so that they're not installed. > > > > Yes...portcheck warns about files in share/applications, and about > > desktop-file-utils. My mistake. > > > > New diff: > > this one is okay for me if someone wants to commit it. >
The .desktop files are broken, "Exec=/usr/bin/joe %F" Easy to patch, but do we really want an X dependency for a simple text editor? It's the sort of thing you might install on a firewall for someone who isn't comfortable with vi/mg.
