On Wed Jan 10, 2018 at 08:59:45PM +0200, Lari Rasku wrote:
> cc ajacoutot@ in case he has something to say re: the webkit errors
> and debugging (bottom).
> 
> libepubdocument uses the (Linux-only?) {ftello,fseeko,fopen}64
> functions, so trying to open an EPUB results in the following console
> prints (and the misleading GUI error message "File type electronic
> book document (application/epub+zip) is not supported"):
> 
>       atril:/usr/local/lib/atril/3/backends/libepubdocument.so: undefined 
> symbol 'ftello64'
>       atril:/usr/local/lib/atril/3/backends/libepubdocument.so: undefined 
> symbol 'fseeko64'
>       atril:/usr/local/lib/atril/3/backends/libepubdocument.so: undefined 
> symbol 'fopen64'
> 
>       (atril:26401): AtrilDocument-WARNING **: Cannot load specified object
> 
>       (atril:26401): AtrilDocument-WARNING **: Cannot load backend 
> 'epubdocument' since file 
> '/usr/local/lib/atril/3/backends/libepubdocument.so' cannot be read.
> 
> This is easy to fix with the following (crude) patch:
> 
> diff --git x11/mate/atril/patches/patch-backend_epub_minizip_ioapi_h 
> x11/mate/atril/patches/patch-backend_epub_minizip_ioapi_h
> new file mode 100644
> index 000000000..ba014a61d
> --- /dev/null
> +++ x11/mate/atril/patches/patch-backend_epub_minizip_ioapi_h
> @@ -0,0 +1,14 @@
> +$OpenBSD$
> +
> +Index: backend/epub/minizip/ioapi.h
> +--- backend/epub/minizip/ioapi.h.orig
> ++++ backend/epub/minizip/ioapi.h
> +@@ -50,7 +50,7 @@
> + #define ftello64 ftell
> + #define fseeko64 fseek
> + #else
> +-#ifdef __FreeBSD__
> ++#ifdef __OpenBSD__

I would prefer:

if defined(__OpenBSD__) || defined(__FreeBSD__)

Anyway I like your commitment to x11/mate/*. Don't worry I quite sure
your diffs will find their way into the tree. You could report them
upstream.

Rafael

Reply via email to