On Fri, Jan 05, 2018 at 01:29:35AM +0000, Thomas Frohwein wrote: > 3) The idea of changing the SDL_GetPlatform string to Linux should > probably be debated and tested.
I had a hunch that SDL_GetPlatform wasn't used much, but of course that's not scientific, so after off-list discussion with awolk@ I grepped through all ports with dependency on SDL2, as well as SDL2 itself. Result is that the only port potentially making use of it is solarus. Since this is a game engine, I can't account for all use cases, but zsdx in ports uses solarus and still works on brief testing. I also looked through jsg@'s updated redeclipse which also doesn't use SDL_GetPlatfrom. (Some ports like this one come with sdl2 libraries or source which I ignored since this shouldn't be affected.) SDL2 itself uses the function to in assigning gamecontroller mappings based on GUID. There are a few uses in the test folder that only log platform or check that the platform string is not empty. In summary, this confirmed my hunch that SDL_GetPlatform isn't really used for anything in ports with the exception of potentially Solarus which doesn't break the application or zsdx though. So it seems that the only effect of changing it from "OpenBSD" to "Linux" would be that the FNA games can run and this would only be temporary until they've been updated. Here's the relevant summary of the grep results: https://pastebin.com/u8v0GBdA Attached port with bumped minor which I overlooked the last time.
sdl2.tgz
Description: Binary data
