On 2018/01/04 07:46, Björn Ketelaars wrote: > On Sun 31/12/2017 14:35, Björn Ketelaars wrote: > > Please find enclosed a diff for bringing archivers/zstd to 1.3.3, which is > > a bug fix release. This diff also enables building of libzstd, and uses the > > correct TEST_TARGET. > > > > Reason for building libzstd is that borgbackup is currently using a bundled > > copy. I would like to replace the bundled copy by the ports version (as > > requested by sthen@). > > > > Comments/OKs? > > > Ping! > > Klemens Nanni found an issue with 'make test', which I'm unable to reproduce. > Is there anyone else who can check the diff and run the test suite? > > Included output from my test (based on the diff).
Tests work here the first time I run them. If I re-run without cleaning the test files, I get the "decoding error" in the "Compress without dictID" test. We didn't have tests at all before, and it seems to be a test problem (I haven't seen it fail on a first run) so I see no reason not to go ahead and commit this, so I'll do that now (with a small tweak to unhide the linker command lines for the libraries).
