On Sat, Dec 30 2017, Frederic Cambus <f...@statdns.com> wrote: > Hi ports@, > > Here is a diff to update hexedit to 1.4.2. > > While there, reformat things slightly and take MAINTAINER. > > Comments? OK?
hexedit works fine here after light testing. Spaces after variable names is a matter of personal preference* IMO. And changing them after the fact means more churn and reducing the usefulness of cvs(1) blame. See cvs diff -w for a much shorter diff. DESCR could be improved, the DESCRIPTION from the manpage reads better: hexedit shows a file both in ASCII and in hexadecimal. The file can be a device as the file is read a piece at a time. You can modify the file and search through it. * I don't really understand why people bother trimming the spaces from Makefile.template; because everybody uses Makefile.template, right? :) > Index: Makefile > =================================================================== > RCS file: /cvs/ports/editors/hexedit/Makefile,v > retrieving revision 1.26 > diff -u -p -r1.26 Makefile > --- Makefile 21 Aug 2017 20:17:59 -0000 1.26 > +++ Makefile 30 Dec 2017 21:59:50 -0000 > @@ -1,26 +1,25 @@ > # $OpenBSD: Makefile,v 1.26 2017/08/21 20:17:59 fcambus Exp $ > > -COMMENT= view and edit files in hexadecimal or ASCII > +COMMENT = view and edit files in hexadecimal or ASCII > > -GH_ACCOUNT= pixel > -GH_PROJECT= hexedit > -GH_TAGNAME= 1.3 > +GH_ACCOUNT = pixel > +GH_PROJECT = hexedit > +GH_TAGNAME = 1.4.2 > > -CATEGORIES= editors > +CATEGORIES = editors > > -HOMEPAGE= http://rigaux.org/hexedit.html > +HOMEPAGE = http://rigaux.org/hexedit.html > > -# GPLv2+ > -PERMIT_PACKAGE_CDROM= Yes > +MAINTAINER = Frederic Cambus <fcam...@openbsd.org> > > -WANTLIB= c ncurses > +# GPLv2+ > +PERMIT_PACKAGE_CDROM = Yes > > -CONFIGURE_STYLE= autoconf > -AUTOCONF_VERSION= 2.69 > +WANTLIB = c curses > > -NO_TEST= Yes > +CONFIGURE_STYLE = autoconf > +AUTOCONF_VERSION = 2.69 > > -post-build: > - m4 -DVERSION=${GH_TAGNAME} ${WRKSRC}/hexedit.1.in > ${WRKSRC}/hexedit.1 > +NO_TEST = Yes > > .include <bsd.port.mk> > Index: distinfo > =================================================================== > RCS file: /cvs/ports/editors/hexedit/distinfo,v > retrieving revision 1.6 > diff -u -p -r1.6 distinfo > --- distinfo 21 Aug 2017 20:17:59 -0000 1.6 > +++ distinfo 30 Dec 2017 21:59:50 -0000 > @@ -1,2 +1,2 @@ > -SHA256 (hexedit-1.3.tar.gz) = iNSJ37iV4ouyRyYTc2/GoUcDT01LA487nReOaWm//XA= > -SIZE (hexedit-1.3.tar.gz) = 29620 > +SHA256 (hexedit-1.4.2.tar.gz) = yB/7Nq+SQ678CIfjPdjkHEsi0JHx8n1BPL2kQ7BEDWY= > +SIZE (hexedit-1.4.2.tar.gz) = 30179 > Index: pkg/DESCR > =================================================================== > RCS file: /cvs/ports/editors/hexedit/pkg/DESCR,v > retrieving revision 1.4 > diff -u -p -r1.4 DESCR > --- pkg/DESCR 15 Dec 2003 21:42:24 -0000 1.4 > +++ pkg/DESCR 30 Dec 2017 21:59:50 -0000 > @@ -1,5 +1,5 @@ > -Hexedit view and edit files in hexadecimal or in ASCII. hexedit > -shows a file both in ASCII and in hexadecimal. The file can be a > -device as the file is not whole read. You can modify the file and > -search through it. You have also copy&paste, and save to file > -functions. Modifications are shown in bold. > +Hexedit view and edit files in hexadecimal or in ASCII. hexedit > +shows a file both in ASCII and in hexadecimal. The file can be a > +device as the file is not whole read. You can modify the file and > +search through it. You have also copy&paste, and save to file > +functions. Modifications are shown in bold. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
