Sat, Dec 23, 2017 at 10:05:27 +0100, Landry Breuil may have written:
> On Fri, Dec 22, 2017 at 04:29:47PM -0800, Matthew Clarke wrote:
> > Hi.
> >
> > The textproc/filepp port has no maintainer, and the current filepp package
> > installs a filepp script that won't run due to the following error:
> >
> > Global symbol "$DESTDIR" requires explicit package name (did you forget
> > to declare "my $DESTDIR"?) at /usr/local/bin/filepp line 43.
> > Execution of /usr/local/bin/filepp aborted due to compilation errors.
[ snip ]
> > [ ... ] Would a ports
> > committer please review the following diff, and commit it if it's OK?
>
>
> Hmm technically the filepp script isn't right since its buildsystem
> replaces @moduledir@ by what ends up in moduledir, defaulting to
> $prefix/share/filepp/modules, and $prefix is assigned ${DESTDIR} by the
> openbsd build system.
> -----
> The moduledir is also set in the filepp script. If you do not run
> configure for whatever reason you should also change @moduledir@ on
> line 40 to the directory you intend to install the modules in (or
> delete the whole line if you are not using modules).
> -----
> There should be some TRUEPREFIX here..
>
> so i think the following is "more correct" in case TRUEPREFIX changes
> someday:
Agreed. Thanks for the review and comments.
BTW, the diff in your email had spaces, not tabs, so patch(1) rejected it,
but it worked fine when I applied it by hand.
--
"With your own code to haunt you, who needs users?"
-- Maarten Wiltink
