On Mon, Dec 11, 2017 at 07:45:06PM +0000, Bryan C. Everly wrote:
> Hello ports@
>
> Taking a second attempt at this. I have updated per Rafael Sadowski
> to remove REVISION and I have placed the sample luminaDesktop.conf
> file in the correct place (versus the FreeBSD place) per Landry
> Breuil.
>
> As mentioned before, attached is a diff that gets us current with the
> latest release of the Lumina Desktop Environment (a BSD-licensed
> desktop environment). At this point, since we have updated our
> version of qt5, we now have all of the same binaries as upstream.
>
> I'd appreciate some further eyes on the diff and then, if it looks
> good, some OK's and a commit.
It *looks* good minor two nits:
> -@unexec-delete rm -f %D/share/icons/material-design-dark/icon-theme.cache
> -@unexec-delete rm -f %D/share/icons/material-design-light/icon-theme.cache
Here you lose those two lines
> -share/examples/lumina/luminaDesktop.conf
> -@sample ${SYSCONFDIR}/luminaDesktop.conf
...
> share/icons/material-design-dark/
> +share/examples/lumina/luminaDesktop.conf
And here you lost the @sample (and the share/examples line was
reordered/put at the wrong place)
Never. Ever. Blindly trust make update-plist. It *always* need manual
checking/extra tweaks, especially wrt @xxx annotations.
