rts/Linker.c includes elf.h for all platform except OpenBSD where it
includes elf_abi.h. In recent snapshots elf_abi.h got removed thanks
to work of Martin Pieuchot. This way, rts/Linker.c includes
non-existent .h file which fails. My "fix" for now is simple to just
s/elf_abi/elf and be done with this for now. As you may see in the
OpenBSD related define there are other things missing in OpenBSD's elf
support, but I'm plan for reviewing this in the future anyway -- hence
my minimalistic way of fixing for now.

If your plans are different, then go ahead with whatever you plan and
do not keep looking back at all.

Thanks! Karel

On Wed, Dec 6, 2017 at 11:20 PM, Matthias Kilian <k...@outback.escape.de> wrote:
> Hi Karel,
>
> On Mon, Dec 04, 2017 at 11:09:33PM +0100, Karel Gardas wrote:
>> attached patch unbreaks GHC compilation issue on snapshot. I would
>> rather keep that simple/stupid before cleaning more those bits in
>> OpenBSD #ifdef. Good for now IMHO.
>
> Well, src and the snapshot i tried yesterday contain both elf.h and
> elf_abi.h, which both do only #include <sys/exec_elf.h>.
>
> So I don't see the point to apply this one *now* to rts/Linker.c
>
> +-#  include <elf_abi.h>
> ++#  include <elf.h>
>
> It may be needed in the future, but I'd like to do this for ghc-8.2
> (which *may* happen this year, if it doesn't require too many updates
> or patches for our existing hs-ports).
>
> Why/how did the build break for you?
>
> Ciao,
>         Kili

Reply via email to