On Sun, Nov 19, 2017 at 06:20:55PM +0100, Jeremie Courreges-Anglas wrote:
> On Wed, Nov 15 2017, Klemens Nanni <k...@posteo.org> wrote:
> > On Wed, Nov 15, 2017 at 11:27:35PM +0100, Klemens Nanni wrote:
> >> Both 0.28 and 0.29 don't actually run tests, do we want to set NO_TEST?
> >>
> >> $ make -s test
> >> ===> Regression tests for ncmpc-0.29v0
> >> ninja: Entering directory `/usr/obj/ports/ncmpc-0.29/build-amd64'
> >> [0/1] Running all tests.
> >> No tests defined.
> > Rephrasing since NO_TEST=Yes is not an option: There are test targets
> > defined in build.ninja but it doesn't seem to run the actual test.
> >
> > I'm no ninja/meson expert so how should we handle this? `make test'
> > yielding no tests and returning zero seems broken to me.
>
> It's fine, see NO_TEST in bsd.port.mk(5).
"It should be left alone for ports with empty regression tests, and for
ports with failing tests" reads to me as "do not set NO_TEST" in this
particular case; where am I wrong?
