Committed with a license marker tweak (it's GPLv3+, or at least it is as of this latest release).

Thanks!

~Brian

On 11/12/17 07:30, Remi Pointel wrote:
On 11/12/17 13:20, Klemens Nanni wrote:
On Sun, Nov 12, 2017 at 03:08:44AM -0500, Brian Callahan wrote:

On 11/11/17 23:14, Klemens Nanni wrote:
Another trivial version bump adding support for github flavored markdown.

I've also ditched VERSION and DISTNAME since GH_* take care of that.

Any takers?

Not directly in your diff, but the post-install routine seems very strange
to me. There are definitely better ways of installing a man page to
${PREFIX}/man than to first install to ${PREFIX}/share/man, then mv from
${PREFIX}/share/man to ${PREFIX}/man and rmdir ${PREFIX}/share/man. You
should consider selecting a better approach.
I did consider replacing that with a new do-install target or patched
Makefile to fix the MANPATH but left it as is in order to keep the diff
minimal.

Here's a new diff using do-install as this shortest way of properlu
dealing with paths and permissions it seeems.


diff --git a/textproc/mdp/Makefile b/textproc/mdp/Makefile
index c02c4c6aa22..eb4748b524a 100644
--- a/textproc/mdp/Makefile
+++ b/textproc/mdp/Makefile
@@ -2,12 +2,9 @@
    COMMENT =    command-line based markdown presentation tool
  -VERSION =     1.0.9
-DISTNAME =    mdp-${VERSION}
-
  GH_ACCOUNT =    visit1985
  GH_PROJECT =    mdp
-GH_TAGNAME =    ${VERSION}
+GH_TAGNAME =    1.0.10
    CATEGORIES =    textproc
  @@ -20,10 +17,10 @@ MAKE_FLAGS =        PREFIX=${PREFIX}
    USE_GMAKE =        Yes
  -post-install:
-    mv ${PREFIX}/share/man/* ${PREFIX}/man/
-    rmdir ${PREFIX}/share/man
-
  NO_TEST =        Yes
  +do-install:
+    ${INSTALL_PROGRAM} ${WRKSRC}/mdp ${PREFIX}/bin
+    ${INSTALL_MAN} ${WRKSRC}/mdp.1 ${PREFIX}/man/man1/
+
  .include <bsd.port.mk>
diff --git a/textproc/mdp/distinfo b/textproc/mdp/distinfo
index e69461c814c..4035efec226 100644
--- a/textproc/mdp/distinfo
+++ b/textproc/mdp/distinfo
@@ -1,2 +1,2 @@
-SHA256 (mdp-1.0.9.tar.gz) = iT4TqaYaibrPKe4UG9n26JNXEDI3AePTZYSku5DhNy0=
-SIZE (mdp-1.0.9.tar.gz) = 36877
+SHA256 (mdp-1.0.10.tar.gz) = c4TBujK9jksRNCVw0hRBZaYGgkmbTLVOUMjrMWTPq8U=
+SIZE (mdp-1.0.10.tar.gz) = 37502


Sounds good to me.

Cheers,

Remi.


Reply via email to