On 11/11/17 22:30, Remi Locherer wrote:
> On Sat, Nov 11, 2017 at 04:57:43PM +0000, Nigel Taylor wrote:
>> On 11/11/17 15:59, Stuart Henderson wrote:
>>> On 2017/11/11 15:46, Nigel Taylor wrote:
>>>> On 11/11/17 14:19, Stuart Henderson wrote:
>>>>> On 2017/11/11 15:04, Jeremie Courreges-Anglas wrote:
>>>>>> On Sat, Nov 04 2017, Remi Locherer <remi.loche...@relo.ch> wrote:
>>>>>>> Hi,
>>>>>>
>>>>>> H Remi,
>>>>>>
>>>>>>> This updates Mojolicious-Plugin-TtRenderer to 1.59. This is needed
>>>>>>> because of the p5-Mojolicious patch I sent before.
>>>>>>>
>>>>>>> OK?
>>>>>>
>>>>>> My p5-ports-fu is rusty. Why the move from modbuild to modinst?
>>>>>
>>>>> Upstream change.
>>>>>
>>>>> OK with me.
>>>>>
>>>>>
>>>>
>>>> Not ok with me.
>>>>
>>>> Module::Install and Module::Build are being abandoned and moving back to
>>>> MakeMaker.
>>>> Upstream has removed Module::Build, and used MakeMaker, not
>>>> Module::Install where
>>>> is the inc/ directory used by Module Install? Where is the actual
>>>> reference
>>>> to Module::Install
>>>
>>> Ah that's better again then. It does work with modinst though, and does
>>> fail with modbuild.
>>>
>> Because modbuild uses Build.PL which no longer exists it fails, modinst uses
>> Makefile.PL same as MakeMaker. Module::Install the Makefile.PL starts with
>> use Module::Install; so requires Module-Install package, MakeMaker
>> is part of core perl so just running the Makefile.PL just runs.
>>
>> The difference is installing the extra package p5-Module-Install, and the
>> deletion of inc/ contents, plus extra CONFIGURE_ARGS setting is added for
>> modinst. Works just a few extras that aren't needed.
>
> This makes sense and it works fine without CONFIGURE_STYLE.
> Thanks for enlighten me! ;-)
>
>>>> I'm looking on CPAN and I just can't see how this is using Module::Install.
>>>>
>>>> Also tests are failing for me
>>>>
>>>> t/lite_app_with_default_layouts.t (Wstat: 256 Tests: 3 Failed: 1)
>>>> Failed test: 3
>>>> Non-zero exit status: 1
>>>> Files=10, Tests=88, 8 wallclock secs ( 0.04 usr 0.07 sys + 3.81 cusr
>>>> 1.42 csys = 5.34 CPU)
>>>> Result: FAIL
>>>> Failed 2/10 test programs. 3/88 subtests failed.
>>>> *** Error 255 in
>>>> /usr/ports/pobj/p5-Mojolicious-Plugin-TtRenderer-1.59/Mojolicious-Plugin-TtRenderer-1.59
>>>> (Makefile:865 'test_dynamic')
>>>> *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2763
>>>> '/usr/ports/pobj/p5-Mojolicious-Plugin-TtRenderer-1.59/.test_done')
>>>> *** Error 1 in
>>>> /usr/ports/mystuff/textproc/p5-Mojolicious-Plugin-TtRenderer
>>>> (/usr/ports/infrastructure/mk/bsd.port.mk:2426 'test')
>>>>
>>>> No mention of failing tests, or reasons given. However this could be down
>>>> to
>>>> the fact Mojo hasn't been updated, this being a plugin, then the plugin
>>>> needs
>>>> reference to the specific versions of p5-Mojo which work a >= in the RDEP.
>>>> But the Makefile.PL gives Mojo 2.51 and later as working with this.
>>>> Either upstream have missed the dependency update or missed updating,
>>>> tests to match changes made.
>>>
>>> They succeed with the p5-Mojolicious update that remi@ sent alongside,
>>> so in that case yes, I agree with adding the version to the dependency.
>>>
>>
>> my revised diff, used updated p5-Mojo. Used 6.33 of Mojo as > 6.24 currently
>> available in ports, and is the version in the upstream Makefile.PL
>>
>
> Makes sense to me.
>
> I could not apply your diff. Looks like tabs have been replaces with
> spaces (happens when copy-pasting).
>
> Here the regenerated diff with your changes.
>
> OK?
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/textproc/p5-Mojolicious-Plugin-TtRenderer/Makefile,v
> retrieving revision 1.5
> diff -u -p -r1.5 Makefile
> --- Makefile 20 Mar 2016 19:57:06 -0000 1.5
> +++ Makefile 11 Nov 2017 22:18:29 -0000
> @@ -4,7 +4,7 @@ COMMENT = Template Renderer Plugin for M
>
> MODULES = cpan
> PKG_ARCH = *
> -DISTNAME = Mojolicious-Plugin-TtRenderer-1.56
> +DISTNAME = Mojolicious-Plugin-TtRenderer-1.59
> CATEGORIES = textproc
>
> # Perl
> @@ -12,10 +12,8 @@ PERMIT_PACKAGE_CDROM = Yes
>
> CPAN_AUTHOR = PLICEASE
>
> -CONFIGURE_STYLE= modbuild
> -
> RUN_DEPENDS = sysutils/p5-Capture-Tiny \
> textproc/p5-Template \
> - www/p5-Mojo
> + www/p5-Mojo>=6.33
>
> .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/textproc/p5-Mojolicious-Plugin-TtRenderer/distinfo,v
> retrieving revision 1.4
> diff -u -p -r1.4 distinfo
> --- distinfo 27 Apr 2015 19:38:21 -0000 1.4
> +++ distinfo 11 Nov 2017 22:18:29 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (Mojolicious-Plugin-TtRenderer-1.56.tar.gz) =
> Tm3uvvu4m2nd+Yz85u4f7aXxABU6PHMMYnwBmKdQXf0=
> -SIZE (Mojolicious-Plugin-TtRenderer-1.56.tar.gz) = 25908
> +SHA256 (Mojolicious-Plugin-TtRenderer-1.59.tar.gz) =
> kATgC7NAzsh7Kqj+uqpd/vHKWU67jRGWq9NBYufp4p0=
> +SIZE (Mojolicious-Plugin-TtRenderer-1.59.tar.gz) = 26180
>
>
Ok to go with p5-Mojo commit.
