On 11/05/17 15:38, Giovanni Bechis wrote: > On Sat, Nov 04, 2017 at 11:45:09AM +0000, Nigel Taylor wrote: >> Ping retested with perl 5.24.3 no issues seen. >> >> Ok for this update? >> > what about adding LWP::Protocol::https to run depends as suggested by > upstream ? > anyway ok for me. > Cheers > Giovanni > LWP-Protocol-https extends libwww you have to have libwww first so LWP-Protocol-https depends on libwww being present, but libwww can be present without LWP-Protocol-https. The suggestion is that you install the extension when needed for https. So ports using https should have a RDEP www/p5-LWP-Protocol-https which depends on www/p5-libwww, ports using just http should have a RDEP www/p5-libwww.
There are a number of distributions that did the dependency the other way around, which mean you can never have a cut down install for http only, it also creates a dependency loop to test LWP-Protocol-https you need libwww which needs LWP-Protocol-https but you haven't built the LWP-Protocol-https package. Just doesn't fit in with the ports tree building and testing of packages, other distributions maybe if you use CPAN to install, build, test. You build and test p5-libwww and create a package, then you build and test p5-LWP-Protocol-https using the built/tested p5-libwww package, then create the package, p5-LWP-Protocol-https never comes before p5-libwww. >> >> >> On 09/24/17 23:02, Nigel Taylor wrote: >>> On 09/24/17 12:49, Stuart Henderson wrote: >>>> On 2017/09/23 23:21, Nigel Taylor wrote: >>>>> This has been taken over by new CPAN author. >>>>> >>>>> Changes most code cleanup and bug fixes. >>>>> >>>>> Built tested on amd64. >>>>> >>>>> Used with get_iplayer/get_flash_videos for some time on main desktop. >>>>> >>>>> Ok? >>>> >>>> I don't see any problem with the diff itself, but it's the wrong time to >>>> update a module affecting ~100 ports (not helped by being an interpreted >>>> language so problems in p5-* often don't show up until runtime). >>>> >>>> So, OK for after unlock. >>>> >>>> >>> Anyway version 6.27 is now out. I've moved on to that now. >>> >>> Built and tested on amd64. >>> >>> Change history for libwww-perl >>> >>> 6.27 2017-09-21 >>> - Switch to Getopt::Long in lwp-download (GH #262) >>> - Fix lwp-request -C (GH #261) >>> - Hide LWP::Protocol::http::Socket, >>> LWP::Protocol::http::SocketMethods and >>> LWP::Debug::TraceHTTP::Socket from PAUSE >>> - Add tests for the "get" & "head" functions (GH #252) >>> - Update lwpcook.pod (GH #256) >>> - Handle undefined values in ->credentials (GH #157) >>> - Fix lwp-mirror options checks. >>> - Update bin/ scripts to use $LWP::VERSION instead of ->Version() >>> - Improve lwp-download --help (GH #262) >>> >>> 6.26 2017-04-12 >>> - Perltidy all apps in the bin/ directory >>> - Make all apps in bin/ use strict and warnings (RT #92633) >>> - Fix bug tracker URL in metadata >>> >>> 6.25 2017-04-03 >>> - Fix LWP::UserAgent docs for request and request_simple that pointed to >>> functions in LWP::Simple rather than LWP::UserAgent >>> - Moved the official bug tracker to GitHub rather than RT. >>> >>> 6.24 2017-03-14 >>> - Document clone methods inability to clone cookie jars (RT #13542) >>> - It is now possible to set the proxy and no_proxy attributes from the >>> constructor of LWP::UserAgent. (GH #124) >>> >>> 6.23 2017-03-06 >>> - Fix bug where Protocol::NNTP called undef on a variable before >>> being done >>> using it. (GH PR #121) >>> - Ran perltidy on LWP::Protocol::NNTP >>> - Re-organized current documentation set. >>> >>> 6.22 2017-03-01 >>> - Update Travis-CI to test on minimum versions of prereqs. (GH PR #109) >>> - Fix tests that depended on a newer version of HTTP::Message (GH PR >>> #119) >>> - Update documentation to reflect behavior difference in ->put() >>> depending >>> on the version of HTTP::Message installed. (GH PR #120) >>> >>> 6.21 2017-02-21 >>> - Ensure that LWP::Simple re-exports some HTTP::Status functions >>> >>> 6.20 2017-02-21 >>> - Converted to use Dist::Zilla >>> - Moved several tests to xt/author >>> >>> 6.19 2017-02-14 >>> - Call HTTP::Status constant functions without & (GH#110) >>> - Make bin scripts use LWP's version and not maintain their own (PR #54) >>> - Fix bug triggered in some cases of auth challenges not having a viable >>> protocol (PR#111) >>> - Remove usage of the 'vars' pragma (GH#113) >>> >>> 6.18 2017-02-03 >>> - Update "timeout" when reusing sockets (PR#90) >>> - Fix bug triggered when calling simple_request() with a malformed URL >>> (PR#108) >>> >>> 6.17 2017-01-31 >>> - Noted another protocol failure message (PR#65) >>> - Removed old use of UNIVERSAL::isa() and swapped evals for >>> Try::Tiny (PR#105) >>> - Standardized the Changes file (GH#106) >>> - Fixed documentation error in lwp-request. >>> >>> 6.16 2017-01-18 >>> - Moved LWP::Protocol::GHTTP into its own dist and removed from here >>> (PR#81) >>> - Updated test suite to use strict/warnings and Test::More (PR#88) >>> - Additional tests for UserAgent coverage (PR#79) >>> - Cleaned up documentation formatting and fixed several typos >>> (PR#87, PR#93) >>> - Stop promoting use of HTTP::Cookies and instead use >>> HTTP::CookieJar::LWP (PR#102) >>> - Added some new documentation to UserAgent and tutorial (PR#68) >>> - Allow default header to carry over when using ->post() in UA (PR#100) >>> >>
