On Thu, Nov 02, 2017 at 10:48:15AM +0000, Stuart Henderson wrote: > On 2017/11/02 11:40, Landry Breuil wrote: > > On Thu, Nov 02, 2017 at 10:26:02AM +0000, Stuart Henderson wrote: > > > On 2017/11/02 11:01, Landry Breuil wrote: > > > > Hi, > > > > > > > > i needed this for qgis which is a huge behemoth, and i dont want to > > > > build it with fullblown debug... so is there any interest in the > > > > following diff, or the way to specify (ie use > > > > MODCMAKE_BUILD_TYPE=RelWithDebInfo in consumer Makefile) it looks wrong > > > > ? > > > > > > How about this? > > > > Much betterer. Allows me to add -DCMAKE_BUILD_TYPE:String=RelWithDebInfo > > to CONFIGURE_ARGS... but then, i'm afraid MODCMAKE_BUILD_SUFFIX is > > undefined :) > > > > I think that's OK isn't it? If you're taking control of build type in a port, > it's reasonable that you handle that part yourself.
Right. ok with your diff then :)
