Stuart Henderson <s...@spacehopper.org> wrote: > On 2017/10/24 20:44, trondd wrote: > > Brian Callahan <bcal...@devio.us> wrote: > > > > > > > > The build moves on even if astyle fails. I'm not wedded to keeping it as > > > a BDEP. You can remove the astyle lines from cdda's Makefile if you like. > > > > > > > The build moves on if astyle is missing or too old. It fails if there is > > an actual style issue. I would have leaned towards excluding it based on > > reducing dependencies but since astyle doesn't bing in any more deps, I > > left it in for completeness. > > The important thing as far as ports goes is whether having this installed > changes the build. If the build works and produces the same thing whether > astyle is installed or not, then it doesn't matter if the dep is listed or > not. > > I must say it seems *really* weird to be running a source code formatting > tool during build. >
I agree and have removed astyle and patched it out of their Makefile.
> > > Indeed you're right. It's a leftover from my trying something else. The
> > > pre-configure routine can be reduced to:
> > > pre-configure:
> > > sed -i -e 's,-Os,${CXXFLAGS},g' -e 's,-Werror,,g'
> > > ${WRKSRC}/Makefile
>
> I'm not a fan of sed with such a short string. Normally we just use patches.
Replaced sed with patch changes. Tweaked the methods of passing CXX* into
the build as well. And it took me a while to figure out that specifying
MODLUA_VERSION removes the FLAVOR from the package name unless you set
MODLUA_SA as well. Correct me if I missed something else with that.
Thanks.
Tim.
cdda-20171013.tgz
Description: application/gzip
