On Wed, Oct 11, 2017 at 03:00:59AM +0200, Jeremie Courreges-Anglas wrote: > On Tue, Oct 10 2017, Remi Locherer <remi.loche...@relo.ch> wrote: > > On Mon, Oct 09, 2017 at 03:02:49PM -0400, Daniel Jakots wrote: > >> On Sat, 7 Oct 2017 23:21:31 +0200, Remi Locherer > >> <remi.loche...@relo.ch> wrote: > >> > >> > Hi, > >> > > >> > this is an update for vdirsyncer to version 0.16.3 which was released > >> > few days ago. See > >> > https://vdirsyncer.pimutils.org/en/stable/changelog.html for changes. > >> > > >> > This patch also enables tests and shortens some long lines in > >> > Makefile. > >> > >> lgtm > >> > >> > The tests depend on two python modules that are not available in ports > >> > yet. py-test-localserver > >> > >> it needs requests as a TDEP, can you put MODPY_PI and MODPY_SETUPTOOLS > >> just after MODULES please? > > > > Thanks for spotting this! Attached the fixed ports. > > Looks good to me. Two nits in py-test-subtesthack: > - s/an/and in COMMENT > - the bdep on devel/py-setuptools_scm doesn't seem to be needed?
Right, py-setuptools_scm is not needed. Somehow I thought it is but could not find any evidence any more ;-) Attached py-setuptools_scm with the two fixes. Thanks, Remi
py-test-subtesthack.tgz
Description: application/tar-gz
