Hi Matthias, On Mon, Oct 09, 2017 at 12:37:54PM +0200, Matthias Schmidt wrote: > I updated the radare2 port to the latest stable Version 1.6.0.> diff --git > Makefile.inc Makefile.inc
Thanks for this. Comments inline. > # In radare, all libs have the same version > -LIBV = 2.0 # 0.10.6 > +LIBV = 2.0 # 1.6.0 Did you check if you needed to bump the major versions here? https://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs > +bin/r2-docker Hrm docker... Is that useful for us? If not, we could delete it in a post-fake, or patch the build system to not install it at all. At fake time: ---8<--- ===> Faking installation for radare2-1.6.0 install -d -m 755 /usr/ports/pobj/radare2-1.6.0/fake-amd64 /usr/ports/pobj/radare2-1.6.0/bin/install -c -d "/usr/ports/pobj/radare2-1.6.0/fake-amd64/usr/local/share/doc /radare2" for FILE in doc/* ; do /usr/ports/pobj/radare2-1.6.0/bin/install -c -m 644 $FILE "/usr/ports/pobj/radare2-1.6.0/fake-amd64/usr/local/share/doc/radare2" ; done install: doc/3D: Inappropriate file type or format install: doc/images: Inappropriate file type or format install: doc/node.js: Inappropriate file type or format install: doc/pdb: Inappropriate file type or format install: doc/sandbox: Inappropriate file type or format --->8--- ^ You probably want to investigate that. Similarly, at package time: ---8<--- ===> Building package for radare2-1.6.0 Create /usr/ports/packages/amd64/all/radare2-1.6.0.tgz Warning: symlink(s) point to non-existent /usr/ports/pobj/radare2-1.6.0/fake-amd64/usr/ports/pobj/radare2-1.6.0/radare2-1.6.0/sys/indent.sh /usr/ports/pobj/radare2-1.6.0/fake-amd64/usr/local/bin/r2-indent Warning: symlink(s) point to non-existent /usr/ports/pobj/radare2-1.6.0/fake-amd64/usr/ports/pobj/radare2-1.6.0/radare2-1.6.0/sys/r2-docker.sh /usr/ports/pobj/radare2-1.6.0/fake-amd64/usr/local/bin/r2-docker --->8--- If you can figure these bits out I will re-review, including the bindings. Cheers! -- Best Regards Edd Barrett http://www.theunixzoo.co.uk
