trondd <tro...@kagu-tsuchi.com> wrote:
> Stuart Henderson <s...@spacehopper.org> wrote:
>
> > On 2017/09/15 19:44, tro...@kagu-tsuchi.com wrote:
> >
> > not built yet, but from a read through:
> >
> > commit log is the place for things like the 'original from'
> >
> > even though the GH_* magic now adds part of the hash, I'd be happier
> > with DISTNAME=cataclysm-dda-2017.09.09 so that the filename matches
> > the port version..
> >
> > please move GH_* up with DISTNAME
> >
> > lua5.1 and the c++ libs should use the variables ${MODLUA_WANTLIB}
> > and ${COMPILER_LIBCXX} - I'm surprised port-lib-depends-check didn't
> > come up with the latter for you?
> >
> > WANTLIB goes immediately after PERMIT_*
> >
> > lua51 should probably be ${MODLUA_BIN}, but if it doesn't like the
> > full path, something like ${MODLUA_DEP}
> >
> > you have WANTLIB hanging off gettext, so this should be LIB not RUN_DEPENDS
> >
> > DESCR looks like it has three possible alternatives of varying
> > descriptiveness in? it seems like one of the three would be enough..
>
> Cleaned up and reorganized. Other than portcheck and port-lib-depends-check
> arguing over intl, they didn't report any other peoblems. They both report
> clean now except for a python script used to convert tilesets whic I don't
> thing is related to building/running.
>
> Tim..
> Now with flavor. Added a no_x11 flavor to build the ncurses version. This is my first flavored port, so keep an eye out. :) Tim.
cdda-flav.tgz
Description: application/gzip
