My elf.h patch solves devel/libdwarf compilation issue, but devel/valgrind still fails due to:
m_coredump/coredump-elf.c:764:32: error: use of undeclared identifier 'NT_PRPSINFO' add_note(¬elist, "CORE", NT_PRPSINFO, &prpsinfo, sizeof(prpsinfo)); the problem is NT_PRPSINFO is not standardized in elf spec so the question is if I shall add this to sys/exec_elf.h or we can also define it inside the coregrind/m_coredump/ coredump-elf.c which already contains definition for NT_PRXFPREG which is from the same family of "common" elf defines for core files... What's the preference in such a case? On Tue, Sep 12, 2017 at 4:23 PM, Christian Weisgerber <na...@mips.inka.de> wrote: > Martin Pieuchot: > >> > So here's a first step, introducing /usr/include/elf.h. Could some of >> > you run a bulk with it and report the possible breakages? >> >> Now that the offending function declaration has been remove from libc >> libelf builds as before. >> >> Could you guys tell us if there's any other fallout from this diff? > > On amd64, two ports failed to build: devel/libdwarf and devel/valgrind. > > ===> devel/libdwarf > print_reloc.c:150:10: error: use of undeclared identifier 'EM_PPC64' > case EM_PPC64: > ^ > > ===> devel/valgrind > m_coredump/coredump-elf.c:105:22: error: use of undeclared identifier > 'EM_X86_64' > ehdr->e_machine = VG_ELF_MACHINE; > ^ > ./pub_core_machine.h:51:31: note: expanded from macro 'VG_ELF_MACHINE' > # define VG_ELF_MACHINE EM_X86_64 > ^ > > -- > Christian "naddy" Weisgerber na...@mips.inka.de
