On 2017/09/06 15:21, Ingo Schwarze wrote: > Hi Jeremie, > > Jeremie Courreges-Anglas wrote on Wed, Sep 06, 2017 at 02:30:16PM +0200: > > > I was cooking up a mail for Alexandr and Rafael but got interrupted. > > Here's the diff I wanted to send. Not a proper fix for upstream either, > > but at least this is more compact than multiple patches. And I'm not > > sure it's a good idea to use stuff like __unused in the ports tree. > > That's elegant, cleaner than my patches, reads well to code inspection, > builds for me on amd64-current, and the two-liner can maybe even be used > by upstream to fix their repos. Not tested at run-time, though. > > You might possibly want to add a comment above it, something like > > # Application software must not redefine macros in the > # implementation namespace. For example, redefining __unused__ > # blows up in our <ctype.h>. > > For the sed(1) commands alone, it is not obvious what is going on. > > Either way, OK schwarze@ for what that's worth. > > Thanks, > Ingo
I agree that adding a comment would be useful. OK with me too.
