On 2017/09/02 01:13, Ayaka Koshibe wrote:
> Sorry, accidentally didn't include ports@ when hitting reply.
> 
> ---------- Forwarded message ----------
> From: Ayaka Koshibe <akosh...@gmail.com>
> Date: Sat, Sep 2, 2017 at 1:11 AM
> Subject: Re: [UPDATE] net/mininet
> To: Stuart Henderson <s...@spacehopper.org>
> 
> 
> > Please add "REVISION=0" to Makefile (somewhere near the DISTNAME/GH_*
> > lines).
> 
> I hope including a few other small fixes to the Makefile is ok.

Yes, OK. But could you remove pyflakes from RUN_DEPENDS as well?
I think that's just used for tests.

> 
> Thanks,
> Ayaka
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/mininet/Makefile,v
> retrieving revision 1.2
> diff -u -p -u -r1.2 Makefile
> --- Makefile    1 Sep 2017 17:08:48 -0000       1.2
> +++ Makefile    2 Sep 2017 08:04:01 -0000
> @@ -3,6 +3,7 @@
>  COMMENT =      emulator for rapid prototyping of software defined networks
> 
>  DISTNAME =     mininet-0.0.20170813
> +REVISION =     0
>  GH_ACCOUNT =   mininet
>  GH_PROJECT =   mininet
>  GH_COMMIT =    87e26ef931ee6063332ceba77db472140f832d3a
> @@ -19,15 +20,14 @@ PERMIT_PACKAGE_CDROM =      Yes
>  WANTLIB =              c
>  MODULES =              lang/python
>  MODPY_SETUPTOOLS =     Yes
> -BUILD_DEPENDS =                devel/help2man \
> -                       devel/pep8
> +BUILD_DEPENDS =                devel/help2man
>  RUN_DEPENDS =          net/socat \
>                         net/iperf \
>                         devel/py-pexpect \
>                         devel/pyflakes
> 
> -MAKE_ENV =     BINDIR=${LOCALBASE}/bin \
> -               MANDIR=${LOCALBASE}/man/man1 \
> +MAKE_ENV =     BINDIR=${PREFIX}/bin \
> +               MANDIR=${PREFIX}/man/man1 \
>                 PKGDIR=${MODPY_SITEPKG} \
>                 PYTHON=${MODPY_BIN}
>  do-build:
> 

Reply via email to