On Sun, Aug 27 2017, Rafael Sadowski <raf...@sizeofvoid.org> wrote: > ping, pong > > On Sat Aug 12, 2017 at 10:01:26AM +0200, Rafael Sadowski wrote: >> Hi All, >> >> please find below a simple diff to update knockpy from 4.0.0 to 4.1.0. >> >> OK? Comments?
Looks good but: 1. the port should probably use MODPY_EGG_VERSION to reduce PLIST churn at update time. 2. the pkg name kinda clashes with make plist. A helper target would help, suggestion below. With point 1 addressed. ok jca@ Index: Makefile =================================================================== RCS file: /d/cvs/ports/security/knockpy/Makefile,v retrieving revision 1.2 diff -u -p -r1.2 Makefile --- Makefile 22 Apr 2017 07:36:27 -0000 1.2 +++ Makefile 27 Aug 2017 19:10:32 -0000 @@ -2,7 +2,8 @@ COMMENT = subdomain scanner -VERSION = 4.0.0 +MODPY_EGG_VERSION = 4.1 +VERSION = 4.1.0 DISTNAME = knockpy-${VERSION} @@ -22,5 +23,10 @@ MODULES = lang/python MODPY_SETUPTOOLS = Yes RUN_DEPENDS = net/py-dnspython + +fix-plist: plist + sed -i \ + 's,site-packages/knock$${MODPY_PY_PREFIX},site-packages/knockpy-,' \ + ${PKGDIR}/PLIST .include <bsd.port.mk> Index: distinfo =================================================================== RCS file: /d/cvs/ports/security/knockpy/distinfo,v retrieving revision 1.2 diff -u -p -r1.2 distinfo --- distinfo 22 Apr 2017 07:36:27 -0000 1.2 +++ distinfo 27 Aug 2017 19:04:13 -0000 @@ -1,2 +1,2 @@ -SHA256 (knockpy-4.0.0.tar.gz) = eR6wtL/Sb5EB8U6RhqlpZoTOe2RlwebVXUIsrIFGsXU= -SIZE (knockpy-4.0.0.tar.gz) = 13352 +SHA256 (knockpy-4.1.0.tar.gz) = PTeM5IK88LpXrOZemdzEduld6ZMO9uAaXsJZQlI9Ypw= +SIZE (knockpy-4.1.0.tar.gz) = 14197 Index: pkg/PLIST =================================================================== RCS file: /d/cvs/ports/security/knockpy/pkg/PLIST,v retrieving revision 1.2 diff -u -p -r1.2 PLIST --- pkg/PLIST 22 Apr 2017 07:36:27 -0000 1.2 +++ pkg/PLIST 27 Aug 2017 19:06:39 -0000 @@ -1,13 +1,13 @@ @comment $OpenBSD: PLIST,v 1.2 2017/04/22 07:36:27 rsadowski Exp $ bin/knockpy lib/python${MODPY_VERSION}/site-packages/knockpy/ -lib/python${MODPY_VERSION}/site-packages/knockpy-4.0-py${MODPY_VERSION}.egg-info/ -lib/python${MODPY_VERSION}/site-packages/knockpy-4.0-py${MODPY_VERSION}.egg-info/PKG-INFO -lib/python${MODPY_VERSION}/site-packages/knockpy-4.0-py${MODPY_VERSION}.egg-info/SOURCES.txt -lib/python${MODPY_VERSION}/site-packages/knockpy-4.0-py${MODPY_VERSION}.egg-info/dependency_links.txt -lib/python${MODPY_VERSION}/site-packages/knockpy-4.0-py${MODPY_VERSION}.egg-info/entry_points.txt -lib/python${MODPY_VERSION}/site-packages/knockpy-4.0-py${MODPY_VERSION}.egg-info/requires.txt -lib/python${MODPY_VERSION}/site-packages/knockpy-4.0-py${MODPY_VERSION}.egg-info/top_level.txt +lib/python${MODPY_VERSION}/site-packages/knockpy-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/ +lib/python${MODPY_VERSION}/site-packages/knockpy-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/PKG-INFO +lib/python${MODPY_VERSION}/site-packages/knockpy-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/SOURCES.txt +lib/python${MODPY_VERSION}/site-packages/knockpy-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/dependency_links.txt +lib/python${MODPY_VERSION}/site-packages/knockpy-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/entry_points.txt +lib/python${MODPY_VERSION}/site-packages/knockpy-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/requires.txt +lib/python${MODPY_VERSION}/site-packages/knockpy-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/top_level.txt lib/python${MODPY_VERSION}/site-packages/knockpy/__init__.py lib/python${MODPY_VERSION}/site-packages/knockpy/__init__.pyc lib/python${MODPY_VERSION}/site-packages/knockpy/knockpy.py @@ -21,6 +21,8 @@ lib/python${MODPY_VERSION}/site-packages lib/python${MODPY_VERSION}/site-packages/knockpy/modules/resolve.pyc lib/python${MODPY_VERSION}/site-packages/knockpy/modules/save_report.py lib/python${MODPY_VERSION}/site-packages/knockpy/modules/save_report.pyc +lib/python${MODPY_VERSION}/site-packages/knockpy/modules/virustotal_subdomains.py +lib/python${MODPY_VERSION}/site-packages/knockpy/modules/virustotal_subdomains.pyc lib/python${MODPY_VERSION}/site-packages/knockpy/modules/wildcard.py lib/python${MODPY_VERSION}/site-packages/knockpy/modules/wildcard.pyc lib/python${MODPY_VERSION}/site-packages/knockpy/modules/zonetransfer.py -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE