On Aug 13, 2017: 13:16, Brian Callahan wrote:
Hi Scott --

On 08/10/17 21:03, Heppler, J. Scott wrote:

Jggimi reviewed the port and found an extra tab and line in the
Makefile.

Version 3 of the attached diff corrects.


This mostly looks good. There's some whitespace/newline tweaks that I can fix on commit.
Question though: I get a lot of errors that look like this:
Could not open file /usr/share/applications/tint2conf.desktop

Should these be tweaked?

I think I have narrowed down this issue.  Upstream provided multiple
examples of configuration files using the linux path;
/usr/share/applications.  In the 12.2 code, these were in the sample
directory.  In the interim, the sample directory was renamed themes.
The 0.12.2 port had a post-install sed entry that edited
/usr/share/applications -> /usr/local/share/applications.

I'm not facile with sed.  Conceptually, I can see several  ways.  1)
Run sed post-install ? will the edit be carried to
/etc/xdg/tint2/tint2rc by the PLIST @sample?  2) sed/Patch the tint2rc
*.tint2rc source 3) Run sed pre-install on the work directory on
themes/*.  Upstream is starting to provide packaging options but does
not presently haveany BSD build options.  The FreeBSD 0.14.5 ports does
not address this issue. Any preferences regarding the 3 options?

Thanks

Scott


It worked just fine here, was even smart enough to preserve my fluxbox bar settings as it took over which was a nice touch.

Also, do you want to be MAINTAINER?

~Brian

Thanks

Scott
On Aug 10, 2017: 10:23, Brian Callahan wrote:
Hi Scott --

I'll take a look at this later today.

~Brian

On 08/09/17 20:01, Heppler, J. Scott wrote:
A revised diff to update x11/tint2 is attached.  Upstream has added 2
new features:  1)  Configurable "Buttons" that attach an icon to a
command.  2) Shell script "Executors" with examples for Network
monitoring and disk usage.

Changelog here:
https://github.com/o9000/tint2

I cvs add'd/rm;d the revised patches and portchecked.

Testers and feedback appreciated.





--
J. Scott Heppler

Penguin Innovations

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

NOTICE: This e-mail message and any attachments may
contain legally privileged and confidential information intended
solely for the use of the intended recipients. If you are not an
intended recipient, you are hereby notified that you have
received this message in error and any review, dissemination,
distribution, copying, or other unauthorized use of this email
and any attachment is strictly prohibited. If you have received
this email in error, please notify the sender immediately and
delete the message and any attachments from your system.

Reply via email to