On 2017/08/16 03:59, Klemens Nanni wrote:
> You should use MODPY_EGG_VERSION and MODPY_SETUPTOOLS,

MODPY_SETUPTOOLS is already there.

If using MODPY_EGG_VERSION here, the PLIST will need to be
manually edited to use it, "make plist" will do the wrong thing.

> SEPARATE_BUILD should be set.

Nope, it creates files in the source directory. SEPARATE_BUILD is for
things which can do a proper out-of-source-tree build.

> textproc/intltool is missing as BUILD_DEPENDS.

Correct, this needs adding.

> I think DESCR's first line would read better if it was a proper sentence.

Reads fine as-is to me.

I'd be OK with importing this with just the intltool BUILD_DEPENDS fixed.
I'd also be OK with MODPY_EGG_VERSION as long as the PLIST is correct.

Reply via email to