On Wed Aug 09, 2017 at 01:03:28PM +0200, Giovanni Bechis wrote:
> Hi,
> enabled yubikey support, tested with challenge-response on yubikey-neo.
> Ok or too many dependencies ?
>  Cheers
>   Giovanni

Thanks for the diff and keepassxc tests with yubikey.
In my opinion there are too many dependencies for a special use-case.

What do you think about a FLAVOR like this:

Index: Makefile
===================================================================
RCS file: /cvs/ports/security/keepassxc/Makefile,v
retrieving revision 1.5
diff -u -p -u -p -r1.5 Makefile
--- Makefile    30 Jul 2017 14:42:01 -0000      1.5
+++ Makefile    9 Aug 2017 14:12:18 -0000
@@ -13,7 +13,7 @@ HOMEPAGE =    https://keepassxc.org
 
 MAINTAINER =   Rafael Sadowski <rsadow...@openbsd.org>
 
-# GPLv2
+# GPLv2 or GPLv3
 PERMIT_PACKAGE_CDROM = Yes
 
 WANTLIB += Qt5Concurrent Qt5Core Qt5DBus Qt5Gui Qt5Network Qt5Widgets
@@ -35,6 +35,16 @@ CONFIGURE_ARGS=      -DWITH_GUI_TESTS=ON \
                -DWITH_XC_AUTOTYPE=ON
 
 TEST_IS_INTERACTIVE =  X11
+
+FLAVORS =      yubikey
+FLAVOR ?=
+
+.if ${FLAVOR:Myubikey}
+LIB_DEPENDS +=         security/yubico/yubico-c \
+                       security/yubico/yubikey-personalization
+CONFIGURE_ARGS +=      -DWITH_XC_YUBIKEY=ON
+WANTLIB += yubikey ykpers-1
+.endif
 
 post-patch:
        cd ${WRKSRC}/src/; sed -i -e 's/Q_OS_LINUX/Q_OS_UNIX/g' \

Reply via email to