Hi Kaashif --
On 07/29/17 08:05, Kaashif Hymabaccus wrote:
Hello everyone,
Please find attached an updated port, incorporating the advice from
bcallah@ and sthen@.
* Port now split into wmutils/core and wmutils/opt
* lsw renamed to lswin, wtf renamed to wintf
* extra newline removed from wmutils/core/pkg/DESCR
Carolyn (and ports@), please tell me what you think. Since you were
making a port, I assume you use the programs. If you have any
experience testing the programs in wmutils/opt, please tell me if
there are any patches needed to fix bugs etc, I have only ever used
the wmutils/core programs and only just now tried out the opt
programs.
Some notes:
core/Makefile:
* 1.4 is used twice, so make it into a V = 1.4 variable at the top of
the Makefile
* You already have CATEGORIES, MAINTAINER, and NO_TEST in the top-level
Makefile, don't repeat them here.
* You can get rid of the MAKE_ENV line and make the MAKE_FLAGS line:
MAKE_FLAGS = CFLAGS="${CFLAGS} -I${X11BASE}/include" \
LDFLAGS="-L${X11BASE}/lib -lxcb -lxcb-util"
to achieve the same effect in fewer lines.
* We prefer sed to perl in the post-patch line.
opt/Makefile:
* 1.0 is used twice, make it into V = 1.0 at the top of the Makefile
* Remove CATEGORIES, MAINTAINER, and NO_TEST
* Remove MAKE_ENV and change the MAKE_FLAGS line to be like
core/Makefile above.
~Brian
