On Sat, Jul 22, 2017 at 08:23:52PM +0300, Vadim Zhukov wrote: > According to documentation [1], the -weak option is meaningful for some > specific cases on AIX and cygwin. We put fake dlopen='' and dlpreopen='' > in .la files anyway, and do not have static arches anymore. Thus I > do not see any reason to actually implement this option. But having > it being recognized helps at least xine-lib to build. > > Since no compilers/linkers do support -weak, this is a safe tweak. Okay? > > -- > WBR, > Vadim Zhukov > > > [1] > https://www.gnu.org/software/libtool/manual/html_node/Linking-with-dlopened-modules.html
Looks fine to me. > > > Index: LT/Mode/Link.pm > =================================================================== > RCS file: /cvs/src/usr.bin/libtool/LT/Mode/Link.pm,v > retrieving revision 1.35 > diff -u -p -r1.35 Link.pm > --- LT/Mode/Link.pm 25 Apr 2017 21:13:15 -0000 1.35 > +++ LT/Mode/Link.pm 22 Jul 2017 17:20:04 -0000 > @@ -153,7 +153,9 @@ sub run > 'static-libtool-libs', > 'thread-safe', # XXX and --thread-safe ? > 'version-info:', > - 'version-number:'); > + 'version-number:', > + 'weak', > + ); > > # XXX options ignored: bindir, dlopen, dlpreopen, no-fast-install, > # no-install, no-undefined, precious-files-regex, > -- Antoine
