SASANO Takayoshi <u...@mx5.nisiq.net> writes:
> Hello,
>
> here is the port of xorriso, iso9660 file manipulator.
>
> For my mistake, I already imported this to CVS tree.
> Sorry and if there is serious problem please remove it on CVS.
No need to remove it IMO.
The port looks good. Some tweaks:
- no need to set REVISION for a new port. Since xorriso is currently
unhooked, we can safely kill it.
- patch-configure can go away if we tweak CPPFLAGS and LDFLAGS through
the environment.
- NO_TEST should only be used if tests fail because there are no tests.
This is not the case here.
- I suggest using upstream's description for DESCR
With the diff below committed, ok jca@ to hook up xorriso in
sysutils/Makefile.
Index: Makefile
===================================================================
RCS file: /d/cvs/ports/sysutils/xorriso/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile 30 Jun 2017 13:26:43 -0000 1.1.1.1
+++ Makefile 30 Jun 2017 15:36:02 -0000
@@ -3,7 +3,6 @@
COMMENT = ISO 9660 Rock Ridge Filesystem Manipulator
DISTNAME = xorriso-1.4.6
-REVISION = 0
CATEGORIES = sysutils
@@ -20,7 +19,7 @@ LIB_DEPENDS = archivers/bzip2 \
converters/libiconv
CONFIGURE_STYLE = gnu
-
-NO_TEST = Yes
+CONFIGURE_ENV = CPPFLAGS="-I${LOCALBASE}/include" \
+ LDFLAGS="-L${LOCALBASE}/lib ${LDFLAGS}"
.include <bsd.port.mk>
Index: patches/patch-configure
===================================================================
RCS file: patches/patch-configure
diff -N patches/patch-configure
--- patches/patch-configure 30 Jun 2017 13:26:43 -0000 1.1.1.1
+++ /dev/null 1 Jan 1970 00:00:00 -0000
@@ -1,14 +0,0 @@
-$OpenBSD: patch-configure,v 1.1.1.1 2017/06/30 13:26:43 uaa Exp $
---- configure.orig Fri Sep 16 22:51:36 2016
-+++ configure Fri Jun 30 00:29:56 2017
-@@ -2529,6 +2529,10 @@ test -n "$target_alias" &&
-
-
- case $target_os in
-+openbsd*)
-+ LDFLAGS="$LDFLAGS -L/usr/local/lib"
-+ CPPFLAGS="$CPPFLAGS -I/usr/local/include"
-+ ;;
- freebsd*)
- LDFLAGS="$LDFLAGS -L/usr/local/lib"
- CPPFLAGS="$CPPFLAGS -I/usr/local/include"
Index: pkg/DESCR
===================================================================
RCS file: /d/cvs/ports/sysutils/xorriso/pkg/DESCR,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 DESCR
--- pkg/DESCR 30 Jun 2017 13:26:43 -0000 1.1.1.1
+++ pkg/DESCR 30 Jun 2017 15:34:04 -0000
@@ -1,2 +1,5 @@
-xorriso copies files info Rock Ridge enhanced ISO 9660 filesystems,
-and vice versa.
+xorriso copies file objects from POSIX compliant filesystems into Rock
+Ridge enhanced ISO 9660 filesystems and allows session-wise manipulation
+of such filesystems. It can load the management information of existing
+ISO images and it writes the session results to optical media or to
+filesystem objects.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
