On 2017/06/01 23:09, Daniel Jakots wrote:
> On Tue, 23 May 2017 12:48:42 +0100, Stuart Henderson
> <s...@spacehopper.org> wrote:
>
> > On 2017/03/07 20:15, Daniel Jakots wrote:
> > > On Tue, 21 Feb 2017 16:13:50 +0000, Stuart Henderson
> > > <s...@spacehopper.org> wrote:
> > >
> > > Sorry for the delay, I slacked a bit.
> > >
> > > > Tests are a bit messed up though, some missing deps - py-coverage,
> > > > py-pexpect, bash, tcsh we have - there's also devel/flake8 of
> > > > which we only have a py2 version (and this was imported as just
> > > > "flake8" rather than "py-flake8" so adding a py3 flavour is going
> > > > to be more fiddly than usual). It also uses "wheel" which isn't
> > > > in ports as far as I can see.
> > >
> > > I talked with flake8 maintainer about splitting it and he said that
> > > it was useless. Users only need the 'binary' and the fact that
> > > it is made from py2 or py3 changes nothing. Sadly he never had the
> > > time to write it on ports@.
> > >
> > > His point sounds legit so I checked for argcomplete and it seems
> > > it's not even used. I just added a patch to zap it from setup.py so
> > > we can drop the need to split flake8.
> >
> > I see where he's coming from, but if you're just working on things
> > written using the current version of python, it's annoying to have to
> > install a legacy version just to run flake8 (and vice-versa, I
> > suppose..)
>
> > > Updated diff, ok danj@ if someone wants to commit
> >
> > Looks good to me. Though I would also support switching flake8 to py3
> > and removing the patch..
>
> You mean adding a py3 flavor, not just moving it to py3 with
> MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3}
> no?
>
> I can remove the dust over the my diffs to add a py3 flavor to flake8
> if it's deemed to be the best way.
"switching flake8 to py3" - I meant just switching it, so just MODPY_VERSION.
I don't really mind which way though.
