On Tue May 16, 2017 at 01:49:01PM +0200, Jeremie Courreges-Anglas wrote: > Jeremie Courreges-Anglas <j...@wxcvbn.org> writes: > > > Rafael Sadowski <raf...@sizeofvoid.org> writes: > > > >> On Sun May 14, 2017 at 08:38:13PM -0500, mitchell wodach wrote: > >>> A whole bunch of tests fail. > >>> > >>> Errors while running CTest > >>> FAILED: CMakeFiles/test.util > >>> cd /usr/ports/pobj/krita-3.1.3/build-amd64 && /usr/local/bin/ctest > >>> --force-new-ctest-process > >>> ninja: build stopped: subcommand failed. > >>> *** Error 1 in . (/usr/ports/devel/cmake/cmake.port.mk:41 'do-test') > >>> *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2690 > >>> '/usr/ports/pobj/krita-3.1.3/build-amd64/.test_done') > >>> *** Error 1 in /usr/ports/myshit/krita > >>> (/usr/ports/infrastructure/mk/bsd.port.mk:2363 'test') > >>> > >>> I don't know if it matters or not if they don't all pass? Someone can > >>> correct me if im wrong. > >>> > >> > >> Hi Mitchell Wodach, > >> > >> thanks for running test. Krita needs `TEST_IS_INTERACTIVE = X11` to > >> provide test results like: > >> > >> 80% tests passed, 34 tests failed out of 173 > >> > >> Please find attached a new version with TEST_IS_INTERACTIVE in Makefile > >> and typo-fix in PLIST from sthen@. > > > > make package warns: > > > > ===> Building package for krita-3.1.3 > > Create /usr/ports/packages/amd64/all/krita-3.1.3.tgz > > LIB_DEPENDS devel/kf5/kitemmodels not needed for graphics/krita ? > > Link to /usr/ports/packages/amd64/ftp/krita-3.1.3.tgz > > Link to /usr/ports/packages/amd64/cdrom/krita-3.1.3.tgz > > > > Except for this, the rest seems good ports-wise, though I'm far from > > being a kf5/kde expert... Also krita seems to work fine here in a dumb > > wm (x11/ratpoison). > > Could you please add comments in the patches? It's not obvious what > they are supposed to achieve. > patch-plugins_extensions_gmic_3rdparty_gmic_CImg_h already has a comment > in the calligra port. > > It seems that some shared libs now provided by krita were part of > calligra before. They should not start at 0.0, but retain their old > version number (bumped, if necessary). >
Please find attached an updated tarball with all your hints here and on ICB. Additional: - update to the last stable version 3.1.4 - fix portcheck noise - move kitemmodels from LIB_DEPENDS to BUILD_DEPENDS Ok? Best regards, Rafael Sadowski
krita_2017_05_30.tar.gz
Description: application/tar-gz
