On 2017/05/27 10:30, Michal Mazurek wrote:
> This port allows using facebook messenger from bitlbee. Requires the
> following diff to bitlbee:
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/bitlbee/Makefile,v
> retrieving revision 1.59
> diff -u -p -r1.59 Makefile
> --- Makefile  27 May 2017 08:01:33 -0000      1.59
> +++ Makefile  27 May 2017 08:22:21 -0000
> @@ -40,7 +40,7 @@ CONFIGURE_ARGS+=    --bindir=${PREFIX}/libe
>  USE_GMAKE=           Yes
>  MAKE_ENV=            "CC=${CC}" "CFLAGS=${CFLAGS}"
>  FAKE_FLAGS=          ETCDIR=${EXAMPLEDIR}
> -FAKE_TARGET=         install install-etc
> +FAKE_TARGET=         install install-etc install-dev
>  SUBST_VARS=          DB_DIR
>  
>  FLAVORS =            libpurple otr

Bump REVISION. I would also set PKGSPEC so that ports depending on bitlbee
are tied to the correct version of bitlbee, otherwise for future bitlbee
updates we'd need to check for any ABI change in the plugin interface and
bump bitlbee-facebook and any other deps. Like this:

V=                      3.5.1
DISTNAME=               bitlbee-$V
PKGSPEC=                bitlbee-=$V
REVISION=               0

> COMMENT=                The Facebook protocol plugin for bitlbee

I'd drop "The" and mention "messenger" too e.g.

COMMENT=                Facebook Messenger protocol plugin for bitlbee

Kill the useless static archive (probably "LIBTOOL_FLAGS= 
--tag=disable-static"),
and probably also @comment the .la file (but check that it works without).

Reply via email to