On 2017/05/07 22:37, Rafael Sadowski wrote:
> On Sun Apr 30, 2017 at 12:08:47PM +0100, Stuart Henderson wrote:
> > On 2017/04/29 23:14, Rafael Sadowski wrote:
> > > is there any good reason to not update libgd? Here are eight good
> > > reasons for a update:
> > 
> > No reason not to update it. Quite a few things depend on it though,
> > so testing is a bit annoying, which might explain why it's old.
> > 
> > > -WANTLIB += c expat fontconfig freetype iconv jpeg m png pthread
> > > -WANTLIB += pthread-stubs ${LIBCXX} tiff vpx z
> > > +#WANTLIB += c expat fontconfig freetype iconv jpeg m png pthread
> > > +#WANTLIB += pthread-stubs ${LIBCXX} tiff vpx z
> > 
> > er?
> > 
> > >  LIB_DEPENDS=     converters/libiconv \
> > >           graphics/jpeg \
> > >           graphics/png \
> > > -         graphics/tiff \
> > > -         multimedia/libvpx
> > > +         graphics/tiff
> > 
> > Need to make sure that dropping libvpx doesn't cause problems in
> > dependent ports.
> > 
> > Didn't they change from libvpx to libwebp rather than dropping webp
> > support completely?
> 
> Please find an new diff with libwebp support from Brad Smith.
> 
> The following ports are affected (diff see below):
> 
> cad/pcb
> graphics/libgphoto2
> net/amule
> net/rtg
> print/texlive/base
> sysutils/modlogan
> www/analog
> 
> Unaffected:
> 
> emulators/fceux
> mail/rspamd
> math/plplot
> net/mldonkey
> net/nagios/nagios
> sysutils/nut
> www/rt
> www/webalizer

These lists don't match the diff; www/analog isn't in the diff,
net/mldonkey is in the diff but listed as unaffected, and
math/graphviz is in the diff but not listed above at all.

(For a commit which touches ports all over the tree, you should
list the directories on the command line rather than letting cvs
iterate over the whole lot, so you want the list to be correct :)

Apart from the extra whitespace in the WANTLIB line for graphviz,
what's in the diff looks correct, but there are some other ports
which I think may be affected too - are you sure that you don't
need changes for libpst, cvsgraph, eduke32, mscgen, p5-GD,
gnuplot, gstreamer1-plugins-good?

Reply via email to