Rafael Sadowski <[email protected]> writes:

> On Mon Apr 24, 2017 at 08:43:38PM +0200, Rafael Sadowski wrote:
>> Hi ports@,
>> 
>> libktorrent without Doxygen and dditional CMake policies.
>> 
>> OK? Comments?
>> 
>> Best regards,
>> 
>> Rafael Sadowski
>> 
>
> New diff below with -DCMAKE_DISABLE_FIND_PACKAGE_Doxygen from jca@.

ok for the doxygen removal part.

Discovering cmake policies here.  Is this change only about shutting up
warnings, or is there also a change in the behavior of the cmake code?
If we're only hiding problems that wait to appear in upcoming cmake
releases, then maybe it's not a good move.

It *seems* that those warnings come from Automoc4Config.cmake or
KDE4Macros.cmake.  Can/should those files be modified, instead of
consumer ports like libktorrent?

[...]

> +# XXX Silently ignore non-existent dependencies
> +CONFIGURE_ARGS +=    -DCMAKE_POLICY_DEFAULT_CMP0053=OLD
> +CONFIGURE_ARGS +=    -DCMAKE_POLICY_DEFAULT_CMP0054=OLD
> +CONFIGURE_ARGS +=    -DCMAKE_POLICY_DEFAULT_CMP0064=OLD
> +# XXX Don't treat ``DEFINITIONS`` as a built-in directory property
> +CONFIGURE_ARGS +=    -DCMAKE_POLICY_DEFAULT_CMP0059=OLD
>  
>  .include <bsd.port.mk>
>

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to