On Mon, Mar 13, 2017 at 08:45:11AM +0000, Stuart Henderson wrote: > On 2017/03/12 17:57, Edd Barrett wrote: > > On Fri, Mar 10, 2017 at 10:54:29AM +0000, Edd Barrett wrote: > > > +# Elinks does not check SSL certificates properly! > > > +# Disable SSL support to protect our users. > > > +CONFIGURE_ARGS += --without-gnutls \ > > > + --without-openssl > > > > Any comments on this? Kill SSL support or kill elinks? > > Is this patch any good for us? > > http://lists.linuxfromscratch.org/pipermail/elinks-dev/2015-June/002099.html
The patch never made it into their git repo, so I'm not sure if it is correct (i'm not versed in the OpenSSL api). I've raised a bug here: https://github.com/nabetaro/elinks/issues/1 (not in their official bugzilla as it is broken) What I'd like to do is: * disable SSL support now. * If after a week or two, there is no evidence that upstream are working to fix the bug, remove the port. Works for you guys? Here's an updated diff with the WANTLIB fixed. OK? Index: Makefile =================================================================== RCS file: /home/edd/cvsync/ports/www/elinks/Makefile,v retrieving revision 1.37 diff -u -p -r1.37 Makefile --- Makefile 30 Jan 2017 10:06:55 -0000 1.37 +++ Makefile 14 Mar 2017 17:48:55 -0000 @@ -1,8 +1,7 @@ # $OpenBSD: Makefile,v 1.37 2017/01/30 10:06:55 jca Exp $ - COMMENT= full-featured text WWW browser DISTNAME= elinks-0.11.7 -REVISION= 10 +REVISION= 11 CATEGORIES= www MASTER_SITES= http://elinks.cz/download/ @@ -24,6 +23,10 @@ CONFIGURE_ARGS+= --with-bzlib \ --enable-gopher \ --enable-256-colors \ --with-libiconv=${LOCALBASE} +# Elinks does not check SSL certificates properly! +# Disable SSL support to protect our users. +CONFIGURE_ARGS += --without-gnutls \ + --without-openssl # don't hide compiler command lines MAKE_ENV= V=true @@ -35,7 +38,7 @@ USE_GMAKE= Yes USE_GROFF = Yes RUN_DEPENDS= devel/gettext -WANTLIB= bz2 crypto c iconv idn ssl z +WANTLIB= bz2 c iconv idn z FLAVORS= lua no_x11 js FLAVOR?= -- Best Regards Edd Barrett http://www.theunixzoo.co.uk
