Hi,

The following diff fixes multimedia/libvpx when trying to build it
with gcc 4.2.1.

It's calling some GCC flags which don't exist in this version.
amd64 and i386 are not affected, because they use clang.

I'm just disabling the offending flags; that's the simplest thing to
do and I can't see any drawback to it (building with clang might just
be a bit more verbose).

No bump, since it just fixes things on archs where it didn't build,
and amd64/i386 output shouldn't change (only warning flags were changed).

Tested on loongson.

Index: patches/patch-libs_mk
===================================================================
RCS file: /cvs/ports/multimedia/libvpx/patches/patch-libs_mk,v
retrieving revision 1.12
diff -u -p -r1.12 patch-libs_mk
--- patches/patch-libs_mk       15 Jan 2017 09:59:11 -0000      1.12
+++ patches/patch-libs_mk       17 Feb 2017 19:26:37 -0000
@@ -1,7 +1,18 @@
 $OpenBSD: patch-libs_mk,v 1.12 2017/01/15 09:59:11 ajacoutot Exp $
---- libs.mk.orig       Thu Jan 12 15:27:27 2017
-+++ libs.mk    Sat Jan 14 18:47:23 2017
-@@ -255,22 +255,17 @@ EXPORT_FILE             := libvpx.def
+--- libs.mk.orig       Thu Jan 12 21:27:27 2017
++++ libs.mk    Fri Feb 17 20:11:49 2017
+@@ -115,10 +115,6 @@ endif
+ 
+ # Suppress -Wextra warnings in third party code.
+ $(BUILD_PFX)third_party/googletest/%.cc.o: CXXFLAGS += 
-Wno-missing-field-initializers
+-# Suppress -Wextra warnings in first party code pending investigation.
+-# https://bugs.chromium.org/p/webm/issues/detail?id=1069
+-$(BUILD_PFX)vp8/encoder/onyx_if.c.o: CFLAGS += -Wno-unknown-warning-option 
-Wno-clobbered
+-$(BUILD_PFX)vp8/decoder/onyxd_if.c.o: CFLAGS += -Wno-unknown-warning-option 
-Wno-clobbered
+ 
+ ifeq ($(CONFIG_MSVS),yes)
+ CODEC_LIB=$(if $(CONFIG_STATIC_MSVCRT),vpxmt,vpxmd)
+@@ -255,22 +251,17 @@ EXPORT_FILE             := libvpx.def
  LIBVPX_SO_SYMLINKS      :=
  LIBVPX_SO_IMPLIB        := libvpx_dll.a
  else
@@ -25,7 +36,7 @@ $OpenBSD: patch-libs_mk,v 1.12 2017/01/1
  $(BUILD_PFX)$(LIBVPX_SO): EXPORTS_FILE = $(EXPORT_FILE)
  
  libvpx.ver: $(call enabled,CODEC_EXPORTS)
-@@ -305,15 +300,7 @@ $(1): $(2)
+@@ -305,15 +296,7 @@ $(1): $(2)
        $(qexec)ln -sf $(2) $$@
  endef
  

Reply via email to