On 2017/01/13 21:38, Daniel Jakots wrote: > On Wed, 11 Jan 2017 23:10:22 +0100, Gregor Best <g...@unobtanium.de> > wrote: > > > Hi people, > > Hi Gregor, > > > this patch updates graphics/glfw from 3.1.2 to 3.2.1 and drops a patch > > that is no longer required. > > > > Here's an updated diff: > - fix WANTLIB > - regen some patches > > I looked at the difference between the two .so and symbols were added, > I guess a major bump would be the safe bet.
If it's new function/s only then minor is enough. If symbols are removed, or if there are ABI changes (different function parameters or changes to exposed structs) major is needed. If you're not sure then major is needed. In this case I think bumping major is the right call, there are too many changes in the source to quickly spot ABI changes, and bumps are cheap for -current (especially for things like this which nothing depends on). But for something which is going to be fed back to -stable, we need to make more effort to avoid major bumps where possible. I'm OK with this, with the bump.